Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1544493002:
CMake: generate SkUserConfig.h with configure_file (Closed)
DescriptionCMake: generate SkUserConfig.h with configure_file
1) It's simpler.
2) It should cache correctly (and not trigger total rebuilds everytime we re-run CMake.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1544493002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
Committed: https://skia.googlesource.com/skia/+/014f06b726267dff5ca1ce094affd605e041fac3
Patch Set 1 #Patch Set 2 : refactor SK_MESA #Patch Set 3 : fix and test fiddle? #Patch Set 4 : -i #Patch Set 5 : revert #Patch Set 6 : dont need else #Messages
Total messages: 28 (12 generated)
Description was changed from ========== CMake: generate SkUserConfig.h with configure_file 1) It's simpler. 2) It should cache correctly (and not trigger total rebuilds everytime we re-run CMake.) BUG=skia: ========== to ========== CMake: generate SkUserConfig.h with configure_file 1) It's simpler. 2) It should cache correctly (and not trigger total rebuilds everytime we re-run CMake.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544493002/1
mtklein@chromium.org changed reviewers: + halcanary@google.com, marco.diiga@gmail.com
mtklein@chromium.org changed required reviewers: + halcanary@google.com, marco.diiga@gmail.com
Marco, can you see if this fixes your Windows caching problems? It looks like it should here on my (Mac) laptop. Hal, how do we know if I'm going to break Fiddle?
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544493002/20001
On 2015/12/21 at 14:05:45, mtklein wrote: > Hal, how do we know if I'm going to break Fiddle? Take a look at experimental/fiddle/fiddle_test.
On 2015/12/21 at 14:18:17, halcanary wrote: > On 2015/12/21 at 14:05:45, mtklein wrote: > > Hal, how do we know if I'm going to break Fiddle? > > Take a look at experimental/fiddle/fiddle_test. Is there a bot that runs this?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2015/12/21 at 14:20:22, mtklein wrote: > On 2015/12/21 at 14:18:17, halcanary wrote: > > On 2015/12/21 at 14:05:45, mtklein wrote: > > > Hal, how do we know if I'm going to break Fiddle? > > > > Take a look at experimental/fiddle/fiddle_test. > > Is there a bot that runs this? Not yet. I never figured out how to set that up.
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544493002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544493002/80001
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544493002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544493002/100001
I think fiddle ought to be good to go at PS 6. Please set up a bot to test fiddle.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2015/12/21 14:05:45, mtklein_C wrote: > Marco, can you see if this fixes your Windows caching problems? It looks like > it should here on my (Mac) laptop. > > Hal, how do we know if I'm going to break Fiddle? Works fine for me, thanks! LGTM :)
mtklein@google.com changed reviewers: + mtklein@google.com
Hal?
lgtm
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544493002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544493002/100001
Message was sent while issue was closed.
Description was changed from ========== CMake: generate SkUserConfig.h with configure_file 1) It's simpler. 2) It should cache correctly (and not trigger total rebuilds everytime we re-run CMake.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot ========== to ========== CMake: generate SkUserConfig.h with configure_file 1) It's simpler. 2) It should cache correctly (and not trigger total rebuilds everytime we re-run CMake.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/014f06b726267dff5ca1ce094affd605e041fac3 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/014f06b726267dff5ca1ce094affd605e041fac3 |
