Issue 1544483003: Auto-rebaseline for r366321

Issue 1544483003: Auto-rebaseline for r366321 (Closed)

Created:
5 years ago by wkorman

Modified:
5 years ago

Reviewers:
Noel Gordon

CC:
chromium-reviews, blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -1 line)			Patch
M	third_party/WebKit/LayoutTests/TestExpectations	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	third_party/WebKit/LayoutTests/platform/android/fast/canvas/canvas-toDataURL-jpeg-maximum-quality-expected.png	View	Binary file		0 comments	Download
D	third_party/WebKit/LayoutTests/platform/linux-precise/fast/canvas/canvas-toDataURL-jpeg-maximum-quality-expected.png	View	Binary file		0 comments	Download
A +	third_party/WebKit/LayoutTests/platform/linux/fast/canvas/canvas-toDataURL-jpeg-maximum-quality-expected.png	View	Binary file		0 comments	Download
A +	third_party/WebKit/LayoutTests/platform/win-xp/fast/canvas/canvas-toDataURL-jpeg-maximum-quality-expected.png	View	Binary file		0 comments	Download
M	third_party/WebKit/LayoutTests/platform/win/fast/canvas/canvas-toDataURL-jpeg-maximum-quality-expected.png	View	Binary file		0 comments	Download

Total messages: 7 (2 generated)

wkorman

Committed patchset #1 (id:1) manually as c05cb747e818bb4044a4ef14dcd0df844bb57710 (presubmit successful).

5 years ago (2015-12-22 09:48:30 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/c05cb747e818bb4044a4ef14dcd0df844bb57710 Cr-Commit-Position: refs/heads/master@{#366582}

5 years ago (2015-12-22 09:48:33 UTC) #4

Noel Gordon

LGTM. The test image is 288 x 253 (letters.png). The test has this style document.body.style.zoom ...

5 years ago (2015-12-22 10:12:07 UTC) #5

Noel Gordon

Also, no all-white images on the right diff anymore. That looks better. Building blink_tests locally ...

5 years ago (2015-12-22 10:49:12 UTC) #6

Noel Gordon

5 years ago (2015-12-22 13:35:17 UTC) #7

Message was sent while issue was closed.

Local % ./run-webkit-test
LayoutTests/fast/canvas/canvas-toDataURL-jpeg-maximum-quality.html result looks
good to me too, test passes.