Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1544483002: [es6] use correct --harmony-destructuring-assignment flag when preparsing (Closed)

Created:
5 years ago by caitp (gmail)
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] use correct --harmony-destructuring-assignment flag when preparsing BUG=v8:811, v8:4636 LOG=N R=adamk@chromium.org, yangguo@chromium.org Committed: https://crrev.com/76f6d2a3c830a13cc9334e6e6bbc571a750ac2c8 Cr-Commit-Position: refs/heads/master@{#32991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/parsing/parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/harmony/destructuring-assignment-lazy.js View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
caitp (gmail)
PTAL --- the original patch was pretty big, simple thing that was missed in the ...
5 years ago (2015-12-21 13:34:06 UTC) #1
caitp (gmail)
On 2015/12/21 13:34:06, caitp wrote: > PTAL --- the original patch was pretty big, simple ...
5 years ago (2015-12-21 13:41:01 UTC) #2
caitp (gmail)
On 2015/12/21 13:41:01, caitp wrote: > On 2015/12/21 13:34:06, caitp wrote: > > PTAL --- ...
5 years ago (2015-12-21 13:42:25 UTC) #5
Yang
On 2015/12/21 13:42:25, caitp wrote: > On 2015/12/21 13:41:01, caitp wrote: > > On 2015/12/21 ...
5 years ago (2015-12-21 13:54:46 UTC) #6
Dan Ehrenberg
lgtm
5 years ago (2015-12-21 19:37:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544483002/1
5 years ago (2015-12-21 19:37:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 20:13:22 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-21 20:13:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76f6d2a3c830a13cc9334e6e6bbc571a750ac2c8
Cr-Commit-Position: refs/heads/master@{#32991}

Powered by Google App Engine
This is Rietveld 408576698