Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1544463002: Move third_party/firefox_jsshell dependency to cloud storage (Closed)

Created:
5 years ago by Bill Hesse
Modified:
4 years, 11 months ago
Reviewers:
ricow1, sra1
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move third_party/firefox_jsshell dependency to cloud storage BUG= R=ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/79b6d81dd22dbe26e580484d7533616608a1438c

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add download hook. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -7 lines) Patch
M DEPS View 1 3 chunks +16 lines, -3 lines 0 comments Download
M third_party/.gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/7zip.tar.gz.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/firefox_jsshell/README.google View 1 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/firefox_jsshell/linux/jsshell.tar.gz.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/firefox_jsshell/mac/jsshell.tar.gz.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/firefox_jsshell/win/jsshell.tar.gz.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/testing/bin/jsshell View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/testing/bin/jsshell.bat View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Bill Hesse
5 years ago (2015-12-21 12:52:25 UTC) #2
Bill Hesse
Added download hook.
5 years ago (2015-12-21 13:02:29 UTC) #3
ricow1
lgtm https://codereview.chromium.org/1544463002/diff/1/tools/testing/bin/jsshell.bat File tools/testing/bin/jsshell.bat (right): https://codereview.chromium.org/1544463002/diff/1/tools/testing/bin/jsshell.bat#newcode13 tools/testing/bin/jsshell.bat:13: "%SCRIPTPATH%..\..\..\third_party\firefox_jsshell\win\jsshell\js.exe" %arguments% long line
5 years ago (2015-12-21 13:08:09 UTC) #4
Bill Hesse
Committed patchset #2 (id:20001) manually as 79b6d81dd22dbe26e580484d7533616608a1438c (presubmit successful).
5 years ago (2015-12-21 13:38:19 UTC) #6
sra1
There have been no dartjs-jsshell results since this CL
4 years, 11 months ago (2015-12-30 23:11:15 UTC) #8
sra1
4 years, 11 months ago (2015-12-30 23:11:17 UTC) #9
Message was sent while issue was closed. 
There have been no dartjs-jsshell results since this CL

Powered by Google App Engine
This is Rietveld 408576698