third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp - Issue 1544423002: Improve positioned/percentHeight descendant/container tracking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

Issue 1544423002: Improve positioned/percentHeight descendant/container tracking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp b/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

index a22c8f9f03ebe2068a9709cc29af887638075e4b..85d695725bbf7c150675874c360a24a5066b8088 100644

--- a/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

@@ -128,7 +128,7 @@ void LayoutRubyRun::addChild(LayoutObject* child, LayoutObject* beforeChild)

// Make sure we don't leave anything in the percentage descendant

// map before moving the children to the new base.

if (hasPercentHeightDescendants())

- clearPercentHeightDescendantsFrom(this);

+ clearPercentHeightDescendants();

rubyBaseSafe()->moveChildren(newRun->rubyBaseSafe(), beforeChild);

}

} else {