third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 1544423002: Improve positioned/percentHeight descendant/container tracking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1544423002: Improve positioned/percentHeight descendant/container tracking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix windows build break Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index 44392ef991f7d9ac0b76c241b5414ef6a7514b0f..f2a2684d736423f5115ec8cf066c8eceff1bdefe 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -6703,8 +6703,8 @@ TEST_P(ParameterizedWebFrameTest, LayoutBlockPercentHeightDescendants)

LayoutBox* percentHeightInAnonymous = toLayoutBox(document->getElementById("percent-height-in-anonymous")->layoutObject());

LayoutBox* percentHeightDirectChild = toLayoutBox(document->getElementById("percent-height-direct-child")->layoutObject());

- EXPECT_TRUE(LayoutBlock::hasPercentHeightDescendant(percentHeightInAnonymous));

- EXPECT_TRUE(LayoutBlock::hasPercentHeightDescendant(percentHeightDirectChild));

+ EXPECT_TRUE(container->hasPercentHeightDescendant(percentHeightInAnonymous));

+ EXPECT_TRUE(container->hasPercentHeightDescendant(percentHeightDirectChild));

ASSERT_TRUE(container->percentHeightDescendants());

ASSERT_TRUE(container->hasPercentHeightDescendants());

« third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp ('k') | no next file » | no next file with comments »