Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 1544373002: Use relative include path to gen-dir to include multiple-stage-generated header (Closed)

Created:
4 years, 11 months ago by tzik
Modified:
4 years, 11 months ago
Reviewers:
haraken, tasak
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use relative include path to gen-dir to include multiple-stage-generated header InternalSettingsGenerated.h is included by V8InternalSettingsGenerated.h as "../../../out/Release/gen/blink/core/testing/InternalSettingsGenerated.h". And it was emitted to the depfile as "gen/../../../out/Release/gen/blink/core/testing/InternalSettingsGenerated.h". That confuses dependency analysis of Ninja and causes unneeded rebuild. This CL converts it to the relative path to out/Release/gen/blink, so that the include path is simplified to "core/testing/InternalSettingsGenerated.h". BUG=531579 Committed: https://crrev.com/760e315dd4247192d0cd0ae86c285c5205da2cb4 Cr-Commit-Position: refs/heads/master@{#366975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544373002/1
4 years, 11 months ago (2015-12-28 10:49:32 UTC) #2
tzik
PTAL
4 years, 11 months ago (2015-12-28 11:01:43 UTC) #6
haraken
LGTM
4 years, 11 months ago (2015-12-28 11:04:11 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-28 11:58:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544373002/1
4 years, 11 months ago (2015-12-28 15:25:15 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-28 15:30:04 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2015-12-28 15:31:28 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/760e315dd4247192d0cd0ae86c285c5205da2cb4
Cr-Commit-Position: refs/heads/master@{#366975}

Powered by Google App Engine
This is Rietveld 408576698