Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1544343002: Add a missing switch-case break in GLES2Decoder (Closed)

Created:
4 years, 12 months ago by tzik
Modified:
4 years, 12 months ago
Reviewers:
bajones
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a missing switch-case break in GLES2Decoder BUG= Committed: https://crrev.com/519fd909a3d23da494a4a24521fcce936405246f Cr-Commit-Position: refs/heads/master@{#366957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544343002/1
4 years, 12 months ago (2015-12-28 00:11:49 UTC) #2
tzik
PTAL. A switch case in GLES2Decoder looks suspicious to me. Doesn't it need a break ...
4 years, 12 months ago (2015-12-28 00:21:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-28 01:11:50 UTC) #6
bajones
This does indeed look like a mistake. Thanks for the fix, LGTM.
4 years, 12 months ago (2015-12-28 02:31:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544343002/1
4 years, 12 months ago (2015-12-28 02:44:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 02:48:23 UTC) #10
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 02:49:26 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/519fd909a3d23da494a4a24521fcce936405246f
Cr-Commit-Position: refs/heads/master@{#366957}

Powered by Google App Engine
This is Rietveld 408576698