Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/toolchain.cc

Issue 1544333002: Convert Pass()→std::move() in //tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/test_with_scope.cc ('k') | tools/gn/value.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/toolchain.cc
diff --git a/tools/gn/toolchain.cc b/tools/gn/toolchain.cc
index 96cf16673ee9d5f2e3b908b8b0595ac448d5a753..2a7035832234fa9da0b3cc61e5120a06f605539d 100644
--- a/tools/gn/toolchain.cc
+++ b/tools/gn/toolchain.cc
@@ -6,6 +6,7 @@
#include <stddef.h>
#include <string.h>
+#include <utility>
#include "base/logging.h"
#include "tools/gn/target.h"
@@ -88,7 +89,7 @@ void Toolchain::SetTool(ToolType type, scoped_ptr<Tool> t) {
DCHECK(type != TYPE_NONE);
DCHECK(!tools_[type].get());
t->SetComplete();
- tools_[type] = t.Pass();
+ tools_[type] = std::move(t);
}
void Toolchain::ToolchainSetupComplete() {
« no previous file with comments | « tools/gn/test_with_scope.cc ('k') | tools/gn/value.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698