Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1544323002: Convert Pass()→std::move() in //device (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
CC:
chromium-reviews, scheib+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //device ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=avi@chromium.org TBR=rockot@chromium.org Committed: https://crrev.com/64f325fc1d271609f83819102a8eba6d54d98d4b Cr-Commit-Position: refs/heads/master@{#366937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -295 lines) Patch
M device/battery/battery_monitor_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M device/battery/battery_status_manager_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/battery/battery_status_service.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/battery/battery_status_service_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_adapter.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_bluez.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_profile_bluez.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 11 chunks +16 lines, -14 lines 0 comments Download
M device/bluetooth/bluetooth_advertisement.h View 2 chunks +9 lines, -9 lines 0 comments Download
M device/bluetooth/bluetooth_advertisement_bluez.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_advertisement_bluez_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_bluez_unittest.cc View 11 chunks +13 lines, -12 lines 0 comments Download
M device/bluetooth/bluetooth_device_bluez.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_discovery_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_gatt_bluez_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_socket_bluez.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_socket_net.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_agent_service_provider.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.cc View 13 chunks +13 lines, -12 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_descriptor_service_provider.cc View 13 chunks +13 lines, -12 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_service_service_provider.cc View 9 chunks +10 lines, -8 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_le_advertisement_service_provider.cc View 9 chunks +17 lines, -14 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_media_endpoint_service_provider.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_profile_service_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/bluetooth/dbus/bluez_dbus_manager.cc View 3 chunks +16 lines, -13 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.cc View 16 chunks +17 lines, -17 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_profile_service_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/bluetooth/test/mock_bluetooth_adapter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/bluetooth/test/mock_bluetooth_gatt_service.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/devices_app/devices_app.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M device/devices_app/usb/device_impl.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M device/devices_app/usb/device_impl_unittest.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M device/devices_app/usb/device_manager_impl.cc View 9 chunks +12 lines, -10 lines 0 comments Download
M device/devices_app/usb/device_manager_impl_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M device/devices_app/usb/fake_permission_provider.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M device/devices_app/usb/type_converters.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M device/hid/device_monitor_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_connection_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/hid/hid_service_linux.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M device/serial/data_receiver.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M device/serial/data_sender.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M device/serial/data_sink_receiver.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M device/serial/data_sink_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M device/serial/data_source_sender.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M device/serial/data_source_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M device/serial/serial_connection.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M device/serial/serial_connection_factory.cc View 4 chunks +12 lines, -10 lines 0 comments Download
M device/serial/serial_connection_unittest.cc View 7 chunks +17 lines, -16 lines 0 comments Download
M device/serial/serial_device_enumerator_linux.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M device/serial/serial_io_handler.cc View 7 chunks +10 lines, -6 lines 0 comments Download
M device/serial/serial_io_handler_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/serial/serial_service_impl.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M device/serial/serial_service_unittest.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M device/serial/test_serial_io_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/test/usb_test_gadget_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/usb/usb_device_filter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/usb/usb_device_handle_impl.cc View 8 chunks +8 lines, -7 lines 0 comments Download
M device/usb/usb_device_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/usb/usb_service_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/vibration/vibration_manager_impl_default.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dcheng
4 years, 11 months ago (2015-12-27 20:51:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544323002/1
4 years, 11 months ago (2015-12-27 20:51:51 UTC) #4
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2015-12-27 21:22:01 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-27 21:53:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544323002/1
4 years, 11 months ago (2015-12-27 21:59:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-27 22:05:18 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-12-27 22:06:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64f325fc1d271609f83819102a8eba6d54d98d4b
Cr-Commit-Position: refs/heads/master@{#366937}

Powered by Google App Engine
This is Rietveld 408576698