Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: content/child/v8_value_converter_impl.cc

Issue 1544273002: Switch to standard integer types in content/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/v8_value_converter_impl.h ('k') | content/child/v8_value_converter_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/v8_value_converter_impl.cc
diff --git a/content/child/v8_value_converter_impl.cc b/content/child/v8_value_converter_impl.cc
index f6db4216755a7d369f59265d5d0df698375431f8..1d4fe41bdb4a993b56c9b8810cf4de40002816b2 100644
--- a/content/child/v8_value_converter_impl.cc
+++ b/content/child/v8_value_converter_impl.cc
@@ -4,6 +4,9 @@
#include "content/child/v8_value_converter_impl.h"
+#include <stddef.h>
+#include <stdint.h>
+
#include <cmath>
#include <string>
@@ -236,7 +239,7 @@ v8::Local<v8::Value> V8ValueConverterImpl::ToV8Array(
CHECK(!child_v8.IsEmpty());
v8::TryCatch try_catch(isolate);
- result->Set(static_cast<uint32>(i), child_v8);
+ result->Set(static_cast<uint32_t>(i), child_v8);
if (try_catch.HasCaught())
LOG(ERROR) << "Setter for index " << i << " threw an exception.";
}
@@ -395,7 +398,7 @@ base::Value* V8ValueConverterImpl::FromV8Array(
base::ListValue* result = new base::ListValue();
// Only fields with integer keys are carried over to the ListValue.
- for (uint32 i = 0; i < val->Length(); ++i) {
+ for (uint32_t i = 0; i < val->Length(); ++i) {
v8::TryCatch try_catch(isolate);
v8::Local<v8::Value> child_v8 = val->Get(i);
if (try_catch.HasCaught()) {
@@ -496,7 +499,7 @@ base::Value* V8ValueConverterImpl::FromV8Object(
scoped_ptr<base::DictionaryValue> result(new base::DictionaryValue());
v8::Local<v8::Array> property_names(val->GetOwnPropertyNames());
- for (uint32 i = 0; i < property_names->Length(); ++i) {
+ for (uint32_t i = 0; i < property_names->Length(); ++i) {
v8::Local<v8::Value> key(property_names->Get(i));
// Extend this test to cover more types as necessary and if sensible.
« no previous file with comments | « content/child/v8_value_converter_impl.h ('k') | content/child/v8_value_converter_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698