Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1544263002: Revert of Disable local_server_unittest on win only (Closed)

Created:
4 years, 12 months ago by nednguyen
Modified:
4 years, 12 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable local_server_unittest on win only (patchset #1 id:1 of https://codereview.chromium.org/1536233004/ ) Reason for revert: May cause flakes to reappear. Original issue's description: > Disable local_server_unittest on win only > > The flaky dashboard shows that the test were failing only on win > (https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiB0ZWxlbWV0cnlfdW5pdHRlc3RzICh3aXRoIHBhdGNoKQw) > > BUG=570955 > > Committed: https://crrev.com/9575f9a4af9115c88bf8ba04e63a77e14e1d2750 > Cr-Commit-Position: refs/heads/master@{#366427} TBR=sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570955 Committed: https://crrev.com/30da2e2321c8a6bcc5a29581b75e0d4ccf82f0c5 Cr-Commit-Position: refs/heads/master@{#366867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/telemetry/telemetry/core/local_server_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nednguyen
Created Revert of Disable local_server_unittest on win only
4 years, 12 months ago (2015-12-25 20:31:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544263002/1
4 years, 12 months ago (2015-12-25 20:31:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-25 20:32:39 UTC) #3
commit-bot: I haz the power
4 years, 12 months ago (2015-12-25 20:33:41 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30da2e2321c8a6bcc5a29581b75e0d4ccf82f0c5
Cr-Commit-Position: refs/heads/master@{#366867}

Powered by Google App Engine
This is Rietveld 408576698