Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1544243002: ash::ImeController should not crash if IME is not initialized yet (Closed)

Created:
4 years, 12 months ago by Alexander Alekseev
Modified:
4 years, 11 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash::ImeController should not crash if IME is not initialized yet BUG=571940 TEST=manual Committed: https://crrev.com/f5a1c26af558661be9750b8ca7cdc1b4759d083b Cr-Commit-Position: refs/heads/master@{#367072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/ui/ash/ime_controller_chromeos.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Alexander Alekseev
Please review.
4 years, 12 months ago (2015-12-25 13:11:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544243002/1
4 years, 12 months ago (2015-12-25 13:25:32 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-25 14:10:37 UTC) #6
stevenjb
lgtm
4 years, 12 months ago (2015-12-28 16:25:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544243002/1
4 years, 11 months ago (2015-12-29 14:44:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-29 15:14:11 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 15:15:14 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f5a1c26af558661be9750b8ca7cdc1b4759d083b
Cr-Commit-Position: refs/heads/master@{#367072}

Powered by Google App Engine
This is Rietveld 408576698