Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1544213002: Introduce code to generate UnlinkedPublicNamespace directly from an AST. (Closed)

Created:
4 years, 12 months ago by Paul Berry
Modified:
4 years, 12 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce code to generate UnlinkedPublicNamespace directly from an AST. This is an initial step towards allowing the entire summary to be generated directly from the AST rather than requiring an element model to be built. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8a445a3f01c1d1e8f3cfb4175150b549f944bae3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+475 lines, -104 lines) Patch
A + pkg/analyzer/lib/src/summary/base.dart View 2 chunks +15 lines, -2 lines 0 comments Download
D pkg/analyzer/lib/src/summary/builder.dart View 1 chunk +0 lines, -22 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 78 chunks +252 lines, -70 lines 0 comments Download
A pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 1 chunk +113 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 6 chunks +78 lines, -3 lines 0 comments Download
M pkg/analyzer/tool/summary/build_sdk_summary.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 5 chunks +13 lines, -4 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 12 months ago (2015-12-25 05:00:09 UTC) #2
scheglov
LGTM
4 years, 12 months ago (2015-12-25 18:23:10 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 8a445a3f01c1d1e8f3cfb4175150b549f944bae3 (presubmit successful).
4 years, 12 months ago (2015-12-26 03:18:03 UTC) #5
Brian Wilkerson
4 years, 12 months ago (2015-12-27 17:07:47 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698