Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 15442002: Move FileAPI sandboxed filesystem related code from webkit/fileapi to webkit/browser/fileapi (Closed)

Created:
7 years, 7 months ago by kinuko
Modified:
7 years, 7 months ago
CC:
chromium-reviews, tzik+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, kinuko+watch
Visibility:
Public.

Description

Move FileAPI sandboxed filesystem related code from webkit/fileapi to webkit/browser/fileapi This moves following files from webkit/fileapi to webkit/browser/fileapi: - obfuscated_file_util* - sandbox_database_test_helper* - sandbox_directory_database* - sandbox_file_stream_writer* - sandbox_mount_point_provider* - sandbox_origin_database* - sandbox_quota_observer* BUG=239710 TBR=avi@chromium.org, calvinlo@chromium.org, thestig@chromium.org, tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201229

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -8278 lines) Patch
M chrome/browser/browsing_data/browsing_data_file_system_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/browser_file_system_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 3 chunks +10 lines, -10 lines 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_mount_point_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/obfuscated_file_util.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + webkit/browser/fileapi/obfuscated_file_util.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/browser/fileapi/obfuscated_file_util_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/sandbox_database_test_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/sandbox_database_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/sandbox_directory_database.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/sandbox_directory_database.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/sandbox_directory_database_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/browser/fileapi/sandbox_file_stream_writer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/sandbox_file_stream_writer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/sandbox_mount_point_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/sandbox_mount_point_provider.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + webkit/browser/fileapi/sandbox_mount_point_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/sandbox_origin_database.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/sandbox_origin_database.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/sandbox_origin_database_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/browser/fileapi/sandbox_quota_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/sandbox_quota_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/webkit_browser_fileapi.gypi View 1 chunk +12 lines, -0 lines 0 comments Download
M webkit/fileapi/dump_file_system.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_context.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_file_stream_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_quota_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_quota_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_writer_delegate_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M webkit/fileapi/local_file_system_operation.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M webkit/fileapi/local_file_system_test_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
D webkit/fileapi/obfuscated_file_util.h View 1 chunk +0 lines, -262 lines 0 comments Download
D webkit/fileapi/obfuscated_file_util.cc View 1 1 chunk +0 lines, -1365 lines 0 comments Download
D webkit/fileapi/obfuscated_file_util_unittest.cc View 1 chunk +0 lines, -2253 lines 0 comments Download
D webkit/fileapi/sandbox_database_test_helper.h View 1 chunk +0 lines, -28 lines 0 comments Download
D webkit/fileapi/sandbox_database_test_helper.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D webkit/fileapi/sandbox_directory_database.h View 1 chunk +0 lines, -124 lines 0 comments Download
D webkit/fileapi/sandbox_directory_database.cc View 1 chunk +0 lines, -926 lines 0 comments Download
D webkit/fileapi/sandbox_directory_database_unittest.cc View 1 chunk +0 lines, -678 lines 0 comments Download
D webkit/fileapi/sandbox_file_stream_writer.h View 1 chunk +0 lines, -92 lines 0 comments Download
D webkit/fileapi/sandbox_file_stream_writer.cc View 1 1 chunk +0 lines, -248 lines 0 comments Download
D webkit/fileapi/sandbox_mount_point_provider.h View 1 chunk +0 lines, -265 lines 0 comments Download
D webkit/fileapi/sandbox_mount_point_provider.cc View 1 chunk +0 lines, -700 lines 0 comments Download
D webkit/fileapi/sandbox_mount_point_provider_unittest.cc View 1 chunk +0 lines, -202 lines 0 comments Download
D webkit/fileapi/sandbox_origin_database.h View 1 chunk +0 lines, -82 lines 0 comments Download
D webkit/fileapi/sandbox_origin_database.cc View 1 chunk +0 lines, -333 lines 0 comments Download
D webkit/fileapi/sandbox_origin_database_unittest.cc View 1 chunk +0 lines, -307 lines 0 comments Download
D webkit/fileapi/sandbox_quota_observer.h View 1 chunk +0 lines, -83 lines 0 comments Download
D webkit/fileapi/sandbox_quota_observer.cc View 1 chunk +0 lines, -140 lines 0 comments Download
M webkit/fileapi/syncable/canned_syncable_file_system.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_operation.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/test_mount_point_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/fileapi/webkit_fileapi.gypi View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kinuko
(Adding more reviewers for load balancing) Mechanical file moving only.
7 years, 7 months ago (2013-05-20 09:09:08 UTC) #1
tzik
lgtm
7 years, 7 months ago (2013-05-20 16:00:17 UTC) #2
calvinlo
lgtm
7 years, 7 months ago (2013-05-21 01:34:54 UTC) #3
kinuko
thestig@: can you stamp chrome/ changes for file renaming? avi@: ditto for content/ changes. thestig: ...
7 years, 7 months ago (2013-05-21 03:40:41 UTC) #4
Lei Zhang
chrome/ lgtm TBR is fine.
7 years, 7 months ago (2013-05-21 03:42:53 UTC) #5
kinuko
Thx! TBR-ing avi@ per our previous conversation.
7 years, 7 months ago (2013-05-21 03:45:22 UTC) #6
Avi (use Gerrit)
Happy to have you tbr renames like this. lgtm
7 years, 7 months ago (2013-05-21 04:05:48 UTC) #7
kinuko
7 years, 7 months ago (2013-05-21 05:15:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r201229 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698