Determine a layer's IsAffectedByPageScale property without using Layer Tree

Determine a layer's IsAffectedByPageScale property without using Layer Tree.

The property is retrieved from TransformTree;
Fix the order of updating the page scale layer and adding transform tree node;
Fix the problem that transform tree sequence number not correctly updated for mask layers;
Fix related cc unit tests where a property tree was not created.

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/73c0fa89da59c8ea5e0d86d1136d7c1a7e68e097
Cr-Commit-Position: refs/heads/master@{#367083}

Committed: https://crrev.com/f66237556448b8edd43cbcece82034ba929de6bb
Cr-Commit-Position: refs/heads/master@{#367923}

[sunxd, 2015-12-23 21:53:03]

Description was changed from

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree

BUG=568777
==========

to

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunxd, 2015-12-23 21:59:14]

Description was changed from

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree.

The property is retrieved from TransformTree;
Fix the order of updating the page scale layer and adding transform tree node;
Fix the problem that transform tree sequence number not correctly updated for
mask layers;
Fix related cc unit tests where a property tree was not created.

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunxd, 2015-12-23 21:59:14]

sunxd@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@chromium.org

[sunxd, 2015-12-23 22:11:04]

Hello,

This change list fixes the bug so that IsAffectedByPageScale property no longer
depends on the layer tree structure. The other property in the bug,
MaxScrollOffset, will be fixed by another change list since the code it
influences does not overlap with this change list.

The changes includes:

* The property is retrieved from TransformTree;
* Fix the order of updating the page scale layer and adding transform tree node;
* Fix the problem that transform tree sequence number not correctly updated for
mask layers;
* Fix related cc unit tests where a property tree was not created.
    - Setting pending tree root layer takes in the parameter as scoped_ptr,
which results in an owner change of the root layers, the change now save the
layers as raw pointers and pass the ownership to pending_trees.

[ajuma, 2015-12-23 22:17:04]

Nice work, this looks great!

https://codereview.chromium.org/1544103002/diff/1/cc/layers/heads_up_display_...
File cc/layers/heads_up_display_layer_impl_unittest.cc (right):

https://codereview.chromium.org/1544103002/diff/1/cc/layers/heads_up_display_...
cc/layers/heads_up_display_layer_impl_unittest.cc:52:
layer->UpdatePropertyTreeTransform();
This line shouldn't be needed (since property trees aren't getting built till
later).

https://codereview.chromium.org/1544103002/diff/1/cc/trees/property_tree_buil...
File cc/trees/property_tree_builder.cc (right):

https://codereview.chromium.org/1544103002/diff/1/cc/trees/property_tree_buil...
cc/trees/property_tree_builder.cc:648:
data_for_children.in_subtree_of_page_scale_layer = true;
Nit: How about moving this inside AddTransformNodeIfNeeded (right before we use
this value), since we already have an is_page_scale_layer bool there.

[sunxd, 2015-12-29 15:57:18]

Thanks! I applied Ali's comments:

* Remove the UpdatePropertyTreeTransform statement;
* Move in_subtree_of_page_scale_layer assignment from BuildPropertyTreesInternal
to AddTransformNodeIfNeeded

[ajuma, 2015-12-29 16:25:14]

On 2015/12/29 15:57:18, sunxd1 wrote:
> Thanks! I applied Ali's comments:
> 
> * Remove the UpdatePropertyTreeTransform statement;
> * Move in_subtree_of_page_scale_layer assignment from
BuildPropertyTreesInternal
> to AddTransformNodeIfNeeded

Thanks, lgtm.

[sunxd, 2015-12-29 17:50:44]

The CQ bit was checked by sunxd@chromium.org

[commit-bot: I haz the power, 2015-12-29 17:50:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1544103002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1544103002/20001

[commit-bot: I haz the power, 2015-12-29 18:16:39]

Description was changed from

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree.

The property is retrieved from TransformTree;
Fix the order of updating the page scale layer and adding transform tree node;
Fix the problem that transform tree sequence number not correctly updated for
mask layers;
Fix related cc unit tests where a property tree was not created.

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree.

The property is retrieved from TransformTree;
Fix the order of updating the page scale layer and adding transform tree node;
Fix the problem that transform tree sequence number not correctly updated for
mask layers;
Fix related cc unit tests where a property tree was not created.

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2015-12-29 18:16:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-29 18:18:27]

Description was changed from

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree.

The property is retrieved from TransformTree;
Fix the order of updating the page scale layer and adding transform tree node;
Fix the problem that transform tree sequence number not correctly updated for
mask layers;
Fix related cc unit tests where a property tree was not created.

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree.

The property is retrieved from TransformTree;
Fix the order of updating the page scale layer and adding transform tree node;
Fix the problem that transform tree sequence number not correctly updated for
mask layers;
Fix related cc unit tests where a property tree was not created.

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/73c0fa89da59c8ea5e0d86d1136d7c1a7e68e097
Cr-Commit-Position: refs/heads/master@{#367083}
==========

[commit-bot: I haz the power, 2015-12-29 18:18:28]

Patchset 2 (id:??) landed as
https://crrev.com/73c0fa89da59c8ea5e0d86d1136d7c1a7e68e097
Cr-Commit-Position: refs/heads/master@{#367083}

[sunxd, 2016-01-06 15:30:07]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1565783002/ by sunxd@chromium.org.

The reason for reverting is: Revert the CL to see if it causes an improvement on
the waterfall. Related to Issue 573267:	10.3% regression in blink_perf.layout at
367076:367083..

[sunxd, 2016-01-06 20:27:53]

Description was changed from

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree.

The property is retrieved from TransformTree;
Fix the order of updating the page scale layer and adding transform tree node;
Fix the problem that transform tree sequence number not correctly updated for
mask layers;
Fix related cc unit tests where a property tree was not created.

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/73c0fa89da59c8ea5e0d86d1136d7c1a7e68e097
Cr-Commit-Position: refs/heads/master@{#367083}
==========

to

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree.

The property is retrieved from TransformTree;
Fix the order of updating the page scale layer and adding transform tree node;
Fix the problem that transform tree sequence number not correctly updated for
mask layers;
Fix related cc unit tests where a property tree was not created.

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/73c0fa89da59c8ea5e0d86d1136d7c1a7e68e097
Cr-Commit-Position: refs/heads/master@{#367083}
==========

[sunxd, 2016-01-06 20:28:01]

The CQ bit was checked by sunxd@chromium.org

[commit-bot: I haz the power, 2016-01-06 20:29:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1544103002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1544103002/20001

[commit-bot: I haz the power, 2016-01-06 21:36:44]

Description was changed from

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree.

The property is retrieved from TransformTree;
Fix the order of updating the page scale layer and adding transform tree node;
Fix the problem that transform tree sequence number not correctly updated for
mask layers;
Fix related cc unit tests where a property tree was not created.

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/73c0fa89da59c8ea5e0d86d1136d7c1a7e68e097
Cr-Commit-Position: refs/heads/master@{#367083}
==========

to

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree.

The property is retrieved from TransformTree;
Fix the order of updating the page scale layer and adding transform tree node;
Fix the problem that transform tree sequence number not correctly updated for
mask layers;
Fix related cc unit tests where a property tree was not created.

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/73c0fa89da59c8ea5e0d86d1136d7c1a7e68e097
Cr-Commit-Position: refs/heads/master@{#367083}
==========

[commit-bot: I haz the power, 2016-01-06 21:36:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-06 21:38:33]

Description was changed from

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree.

The property is retrieved from TransformTree;
Fix the order of updating the page scale layer and adding transform tree node;
Fix the problem that transform tree sequence number not correctly updated for
mask layers;
Fix related cc unit tests where a property tree was not created.

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/73c0fa89da59c8ea5e0d86d1136d7c1a7e68e097
Cr-Commit-Position: refs/heads/master@{#367083}
==========

to

==========
Determine a layer's IsAffectedByPageScale property without using Layer Tree.

The property is retrieved from TransformTree;
Fix the order of updating the page scale layer and adding transform tree node;
Fix the problem that transform tree sequence number not correctly updated for
mask layers;
Fix related cc unit tests where a property tree was not created.

BUG=568777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/73c0fa89da59c8ea5e0d86d1136d7c1a7e68e097
Cr-Commit-Position: refs/heads/master@{#367083}

Committed: https://crrev.com/f66237556448b8edd43cbcece82034ba929de6bb
Cr-Commit-Position: refs/heads/master@{#367923}
==========

[commit-bot: I haz the power, 2016-01-06 21:38:34]

Patchset 2 (id:??) landed as
https://crrev.com/f66237556448b8edd43cbcece82034ba929de6bb
Cr-Commit-Position: refs/heads/master@{#367923}

[sunxd, 2016-01-17 02:30:24]

Patchset #3 (id:40001) has been deleted