Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1544033003: Switch to standard integer types in base/prefs/. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
4 years, 12 months ago
Reviewers:
battre
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in base/prefs/. BUG=138542 TBR=battre@chromium.org Committed: https://crrev.com/9ef8bb0455f71e6911e759134a9bbf61a6129af2 Cr-Commit-Position: refs/heads/master@{#366805}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -125 lines) Patch
M base/prefs/default_pref_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/prefs/default_pref_store_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/prefs/json_pref_store.h View 4 chunks +9 lines, -7 lines 0 comments Download
M base/prefs/json_pref_store.cc View 8 chunks +12 lines, -8 lines 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 6 chunks +8 lines, -5 lines 0 comments Download
M base/prefs/overlay_user_pref_store.h View 2 chunks +7 lines, -5 lines 0 comments Download
M base/prefs/overlay_user_pref_store.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M base/prefs/pref_change_registrar.h View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_member.h View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_notifier_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/prefs/pref_notifier_impl_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/prefs/pref_registry.h View 4 chunks +7 lines, -4 lines 0 comments Download
M base/prefs/pref_registry.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M base/prefs/pref_registry_simple.h View 3 chunks +23 lines, -16 lines 0 comments Download
M base/prefs/pref_registry_simple.cc View 2 chunks +17 lines, -18 lines 0 comments Download
M base/prefs/pref_service.h View 4 chunks +9 lines, -6 lines 0 comments Download
M base/prefs/pref_service.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M base/prefs/pref_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_service_unittest.cc View 4 chunks +15 lines, -11 lines 0 comments Download
M base/prefs/pref_store.h View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_value_map.h View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_value_store.h View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_value_store.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/prefs/scoped_user_pref_update.h View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/testing_pref_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/prefs/testing_pref_store.h View 2 chunks +7 lines, -5 lines 0 comments Download
M base/prefs/testing_pref_store.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/prefs/value_map_pref_store.h View 2 chunks +7 lines, -5 lines 0 comments Download
M base/prefs/value_map_pref_store.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/prefs/writeable_pref_store.h View 5 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544033003/1
5 years ago (2015-12-24 04:07:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-24 05:29:43 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9ef8bb0455f71e6911e759134a9bbf61a6129af2 Cr-Commit-Position: refs/heads/master@{#366805}
4 years, 12 months ago (2015-12-24 05:30:46 UTC) #5
battre
4 years, 12 months ago (2015-12-24 06:57:48 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698