Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1544013002: X87: [turbofan] Exhaustive switches for MachineRepresentation. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Exhaustive switches for MachineRepresentation. port 739c018735db0c6750ced519ac820e8579630195 (r33011) original commit message: BUG= Committed: https://crrev.com/eb5ecd8386a33fc105c3233a4cf2ebfedfea0ea0 Cr-Commit-Position: refs/heads/master@{#33018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 8 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-23 02:41:07 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-23 04:49:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544013002/1
5 years ago (2015-12-23 04:49:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-23 05:09:04 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-23 05:09:32 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eb5ecd8386a33fc105c3233a4cf2ebfedfea0ea0
Cr-Commit-Position: refs/heads/master@{#33018}

Powered by Google App Engine
This is Rietveld 408576698