Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1543973002: [turbofan] move optimizer - CompressBlock cleanup (Closed)

Created:
5 years ago by Mircea Trofin
Modified:
5 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] move optimizer - CompressBlock cleanup. I believe the code reads easier after this change. The original code probably dates back to when we had 4 gap positions. Now that there are only 2, the logic can be simpler by avoiding a loop and instead treating each case explicitly: no gaps; gaps just at end; gaps at start and maybe end. That way, it is also easier to understand how the moves get pushed downwards. This is what got me to make this change in the first place: trying to work out a finer grained move optimization. BUG= Committed: https://crrev.com/3f7e96df21c251d7120c0ae86248406878158afe Cr-Commit-Position: refs/heads/master@{#33016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -15 lines) Patch
M src/compiler/move-optimizer.cc View 2 chunks +28 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Benedikt Meurer
LGTM.
5 years ago (2015-12-23 04:55:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543973002/1
5 years ago (2015-12-23 04:58:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-23 04:59:14 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-23 04:59:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f7e96df21c251d7120c0ae86248406878158afe
Cr-Commit-Position: refs/heads/master@{#33016}

Powered by Google App Engine
This is Rietveld 408576698