Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2650)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 154393003: Implement eager instantiation and canonicalization of type arguments at run (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 32446)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -1931,25 +1931,6 @@
}
-LocationSummary*
-AllocateObjectWithBoundsCheckInstr::MakeLocationSummary(bool opt) const {
- return MakeCallSummary();
-}
-
-
-void AllocateObjectWithBoundsCheckInstr::EmitNativeCode(
- FlowGraphCompiler* compiler) {
- compiler->GenerateRuntimeCall(token_pos(),
- deopt_id(),
- kAllocateObjectWithBoundsCheckRuntimeEntry,
- 3,
- locs());
- __ Drop(3);
- ASSERT(locs()->out().reg() == EAX);
- __ popl(EAX); // Pop new instance.
-}
-
-
class BoxDoubleSlowPath : public SlowPathCode {
public:
explicit BoxDoubleSlowPath(Instruction* instruction)
@@ -2150,8 +2131,7 @@
Register instantiator_reg = locs()->in(0).reg();
Register result_reg = locs()->out().reg();
- // 'instantiator_reg' is the instantiator AbstractTypeArguments object
- // (or null).
+ // 'instantiator_reg' is the instantiator TypeArguments object (or null).
// A runtime call to instantiate the type is required.
__ PushObject(Object::ZoneHandle()); // Make room for the result.
__ PushObject(type());
@@ -2184,8 +2164,7 @@
Register instantiator_reg = locs()->in(0).reg();
Register result_reg = locs()->out().reg();
- // 'instantiator_reg' is the instantiator AbstractTypeArguments object
- // (or null).
+ // 'instantiator_reg' is the instantiator TypeArguments object (or null).
ASSERT(!type_arguments().IsUninstantiatedIdentity() &&
!type_arguments().CanShareInstantiatorTypeArguments(
instantiator_class()));
@@ -2235,8 +2214,8 @@
Register result_reg = locs()->out().reg();
ASSERT(instantiator_reg == result_reg);
- // instantiator_reg is the instantiator type argument vector, i.e. an
- // AbstractTypeArguments object (or null).
+ // instantiator_reg is the instantiator type argument vector,
+ // i.e. a TypeArguments object (or null).
ASSERT(!type_arguments().IsUninstantiatedIdentity() &&
!type_arguments().CanShareInstantiatorTypeArguments(
instantiator_class()));
@@ -2277,8 +2256,7 @@
Register instantiator_reg = locs()->in(0).reg();
ASSERT(locs()->out().reg() == instantiator_reg);
- // instantiator_reg is the instantiator AbstractTypeArguments object
- // (or null).
+ // instantiator_reg is the instantiator TypeArguments object (or null).
ASSERT(!type_arguments().IsUninstantiatedIdentity() &&
!type_arguments().CanShareInstantiatorTypeArguments(
instantiator_class()));

Powered by Google App Engine
This is Rietveld 408576698