Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: chrome/browser/extensions/extension_web_ui_unittest.cc

Issue 1543923002: [Extensions] Fix chrome url override settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/message_loop/message_loop.h" 6 #include "base/message_loop/message_loop.h"
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "chrome/browser/extensions/extension_service.h" 8 #include "chrome/browser/extensions/extension_service.h"
9 #include "chrome/browser/extensions/extension_web_ui.h" 9 #include "chrome/browser/extensions/extension_web_ui.h"
10 #include "chrome/browser/extensions/extension_web_ui_override_registrar.h"
10 #include "chrome/browser/extensions/test_extension_system.h" 11 #include "chrome/browser/extensions/test_extension_system.h"
11 #include "chrome/test/base/testing_profile.h" 12 #include "chrome/test/base/testing_profile.h"
12 #include "content/public/test/test_browser_thread.h" 13 #include "content/public/test/test_browser_thread.h"
13 #include "extensions/browser/extension_system.h" 14 #include "extensions/browser/extension_system.h"
14 #include "extensions/common/extension.h" 15 #include "extensions/common/extension.h"
15 #include "extensions/common/extension_builder.h" 16 #include "extensions/common/extension_builder.h"
16 #include "extensions/common/manifest_constants.h" 17 #include "extensions/common/manifest_constants.h"
17 #include "testing/gtest/include/gtest/gtest.h" 18 #include "testing/gtest/include/gtest/gtest.h"
18 19
19 #if defined(OS_CHROMEOS) 20 #if defined(OS_CHROMEOS)
20 #include "chrome/browser/chromeos/login/users/scoped_test_user_manager.h" 21 #include "chrome/browser/chromeos/login/users/scoped_test_user_manager.h"
21 #include "chrome/browser/chromeos/settings/cros_settings.h" 22 #include "chrome/browser/chromeos/settings/cros_settings.h"
22 #include "chrome/browser/chromeos/settings/device_settings_service.h" 23 #include "chrome/browser/chromeos/settings/device_settings_service.h"
23 #endif 24 #endif
24 25
25 namespace extensions { 26 namespace extensions {
26 27
28 namespace {
29
30 scoped_ptr<KeyedService> BuildOverrideRegistrar(
31 content::BrowserContext* context) {
32 return make_scoped_ptr(new ExtensionWebUIOverrideRegistrar(context));
33 }
34
35 } // namespace
36
27 class ExtensionWebUITest : public testing::Test { 37 class ExtensionWebUITest : public testing::Test {
28 public: 38 public:
29 ExtensionWebUITest() 39 ExtensionWebUITest()
30 : ui_thread_(content::BrowserThread::UI, &message_loop_) {} 40 : ui_thread_(content::BrowserThread::UI, &message_loop_) {}
31 41
32 protected: 42 protected:
33 void SetUp() override { 43 void SetUp() override {
34 profile_.reset(new TestingProfile()); 44 profile_.reset(new TestingProfile());
35 TestExtensionSystem* system = 45 TestExtensionSystem* system =
36 static_cast<TestExtensionSystem*>(ExtensionSystem::Get(profile_.get())); 46 static_cast<TestExtensionSystem*>(ExtensionSystem::Get(profile_.get()));
37 extension_service_ = system->CreateExtensionService( 47 extension_service_ = system->CreateExtensionService(
38 base::CommandLine::ForCurrentProcess(), base::FilePath(), false); 48 base::CommandLine::ForCurrentProcess(), base::FilePath(), false);
49 ExtensionWebUIOverrideRegistrar::GetFactoryInstance()->SetTestingFactory(
50 profile_.get(), &BuildOverrideRegistrar);
51 ExtensionWebUIOverrideRegistrar::GetFactoryInstance()->Get(profile_.get());
39 } 52 }
40 53
41 void TearDown() override { 54 void TearDown() override {
42 profile_.reset(); 55 profile_.reset();
43 message_loop_.RunUntilIdle(); 56 message_loop_.RunUntilIdle();
44 } 57 }
45 58
46 scoped_ptr<TestingProfile> profile_; 59 scoped_ptr<TestingProfile> profile_;
47 ExtensionService* extension_service_; 60 ExtensionService* extension_service_;
48 base::MessageLoop message_loop_; 61 base::MessageLoop message_loop_;
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 116
104 // Unregister non-component extension. Only component extension remaining. 117 // Unregister non-component extension. Only component extension remaining.
105 ExtensionWebUI::UnregisterChromeURLOverrides( 118 ExtensionWebUI::UnregisterChromeURLOverrides(
106 profile_.get(), URLOverrides::GetChromeURLOverrides(ext_unpacked.get())); 119 profile_.get(), URLOverrides::GetChromeURLOverrides(ext_unpacked.get()));
107 url = GURL("chrome://bookmarks"); 120 url = GURL("chrome://bookmarks");
108 EXPECT_TRUE(ExtensionWebUI::HandleChromeURLOverride(&url, profile_.get())); 121 EXPECT_TRUE(ExtensionWebUI::HandleChromeURLOverride(&url, profile_.get()));
109 EXPECT_EQ(url, expected_component_override_url); 122 EXPECT_EQ(url, expected_component_override_url);
110 123
111 // This time the non-component extension was registered more recently and 124 // This time the non-component extension was registered more recently and
112 // should still take precedence. 125 // should still take precedence.
113 ExtensionWebUI::RegisterChromeURLOverrides( 126 ExtensionWebUI::RegisterOrActivateChromeURLOverrides(
114 profile_.get(), URLOverrides::GetChromeURLOverrides(ext_unpacked.get())); 127 profile_.get(), URLOverrides::GetChromeURLOverrides(ext_unpacked.get()));
115 url = GURL("chrome://bookmarks"); 128 url = GURL("chrome://bookmarks");
116 EXPECT_TRUE(ExtensionWebUI::HandleChromeURLOverride(&url, profile_.get())); 129 EXPECT_TRUE(ExtensionWebUI::HandleChromeURLOverride(&url, profile_.get()));
117 EXPECT_EQ(url, expected_unpacked_override_url); 130 EXPECT_EQ(url, expected_unpacked_override_url);
118 } 131 }
119 132
120 } // namespace extensions 133 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698