chrome/android/java/res/layout/infobar_control_toggle.xml - Issue 1543913002: Add support for images with descriptions to infobars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/infobar_control_toggle.xml

Issue 1543913002: Add support for images with descriptions to infobars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, ready to review Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/layout/infobar_control_icon_with_description.xml ('K') | « chrome/android/java/res/layout/infobar_control_icon_with_description.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarControlLayout.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarControlLayout.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/infobar_control_toggle.xml

diff --git a/chrome/android/java/res/layout/infobar_control_toggle.xml b/chrome/android/java/res/layout/infobar_control_toggle.xml

index 987779b8b1fdd34698132fe80dc6a887c4a586a6..9a65327b7619e8ff2b0816f83de5383f8c3be14c 100644

--- a/chrome/android/java/res/layout/infobar_control_toggle.xml

+++ b/chrome/android/java/res/layout/infobar_control_toggle.xml

@@ -11,19 +11,15 @@

android:gravity="center_vertical">

<ImageView

- android:id="@+id/control_toggle_icon"

+ android:id="@+id/control_icon"

android:layout_width="wrap_content"

android:layout_height="wrap_content"

android:layout_marginEnd="@dimen/infobar_control_margin_between_items"

android:scaleType="centerInside"

android:contentDescription="@null" />

- <!-- TODO(dfalcantara): Line spacing multiplier is applied to all lines in JB & KK, even if the

- TextView has only one line. This throws off vertical alignment. Find

- a solution that hopefully doesn't involve subclassing the TextView.

- -->

<TextView

- android:id="@+id/control_toggle_message"

+ android:id="@+id/control_message"

android:layout_width="0dp"

android:layout_height="wrap_content"

android:layout_weight="1"