Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7950)

Unified Diff: chrome/test/kasko/py/kasko/report.py

Issue 1543803005: Added an integration test for kasko hang reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Using components for integration test. Rewrote unittests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/kasko/py/kasko/report.py
diff --git a/chrome/test/kasko/py/kasko/report.py b/chrome/test/kasko/py/kasko/report.py
index 6e0c350732b6583dcef240055e4dd27fc5ddd229..f70b53ba4c1728d31ccf0004553d76c6e57676d4 100755
--- a/chrome/test/kasko/py/kasko/report.py
+++ b/chrome/test/kasko/py/kasko/report.py
@@ -33,3 +33,12 @@ def ValidateCrashReport(report, expectations=None):
if expected_key not in report:
_LOGGER.error('Missing expected "%s" crash key.', expected_key)
raise Exception('"%s" integration appears broken.' % error)
+
+
+def ValidateNonEmptyCrashKeys(report, expected_keys):
chrisha 2016/01/20 22:20:31 You should be able to use the above validation log
Patrick Monette 2016/01/21 00:05:10 Done.
+ for expected_key in expected_keys:
+ if expected_key not in report:
+ raise Exception('Missing expected "%s" crash key.', expected_key)
+
+ if report[expected_key] == '':
+ raise Exception('Empty value for expected key "%s".' % expected_key)

Powered by Google App Engine
This is Rietveld 408576698