Added an integration test for kasko hang reports

Added an integration test for kasko hang reports

Committed: https://crrev.com/3955a4ff6fb5b66408cf3748c9dcd4bd22885c80
Cr-Commit-Position: refs/heads/master@{#372442}

[Patrick Monette, 2015-12-23 17:20:54]

Patchset #1 (id:1) has been deleted

[Patrick Monette, 2015-12-23 17:24:46]

pmonette@chromium.org changed reviewers:
+ chrisha@chromium.org

[Patrick Monette, 2015-12-23 17:24:46]

Chrisha: Please take a look at the integration test.
siggi: Please review changes in the watcher.

https://codereview.chromium.org/1543803005/diff/20001/chrome/test/kasko/hang_...
File chrome/test/kasko/hang_watcher_integration_test.py (right):

https://codereview.chromium.org/1543803005/diff/20001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:371: if
proc.Properties_('ParentProcessId').Value != parent_pid:
chrisha: Does this work on your PC?

[Patrick Monette, 2015-12-23 17:25:19]

pmonette@chromium.org changed reviewers:
+ siggi@chromium.org

[Patrick Monette, 2016-01-08 19:26:25]

PTAL Chris.

[Sigurður Ásgeirsson, 2016-01-11 19:42:59]

nice - I think you may need to select harder for the process singleton window.
Maybe testing that the window name is a file path, and exists?

https://codereview.chromium.org/1543803005/diff/40001/chrome/test/kasko/hang_...
File chrome/test/kasko/hang_watcher_integration_test.py (right):

https://codereview.chromium.org/1543803005/diff/40001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:8: This test ensures that
Kasko is able to detect when Chrome is hanged and to
is hanged -> hangs
also I think you intend to name the hang watcher rather than Kasko here?

https://codereview.chromium.org/1543803005/diff/40001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:12: Note that this test only
works against non-component Release and Official builds
the bulk of this file wants to be reused rather than copied.

https://codereview.chromium.org/1543803005/diff/40001/components/browser_watc...
File components/browser_watcher/window_hang_monitor_win.cc (right):

https://codereview.chromium.org/1543803005/diff/40001/components/browser_watc...
components/browser_watcher/window_hang_monitor_win.cc:29: HWND
FindChromeMessageWindow(base::ProcessId pid) {
now that I think about it, I'm not sure this is "good enough". The problem is
that this will find *A* message window, but I don't know that there's precisely
zero or one of those per chrome instance. The lifetime of other message windows
may or may not be appropriate for hang monitoring.

https://codereview.chromium.org/1543803005/diff/40001/components/browser_watc...
components/browser_watcher/window_hang_monitor_win.cc:34: if
(GetWindowClassName(candidate) == L"Chrome_MessageWindow" &&
doesn't matter a whole lot, but you can avoid a bunch of string copying here by
naming this function something like IsWindowClassName, and passing it a
stringpiece.

[chrisha, 2016-01-12 19:42:15]

https://codereview.chromium.org/1543803005/diff/40001/chrome/test/kasko/hang_...
File chrome/test/kasko/hang_watcher_integration_test.py (right):

https://codereview.chromium.org/1543803005/diff/40001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:12: Note that this test only
works against non-component Release and Official builds
On 2016/01/11 19:42:58, Sigurður Ásgeirsson wrote:
> the bulk of this file wants to be reused rather than copied.

I've got a CL in progress which lifts all of the pieces to reusable components
in a module. Maybe wait for that to land and build on top of it?

https://codereview.chromium.org/1582613002/

[Patrick Monette, 2016-01-12 19:49:44]

sgtm

[Patrick Monette, 2016-01-20 17:21:35]

Please take another look Siggi for hang watcher stuff.
chrisha: Can you look at the integration test?

https://codereview.chromium.org/1543803005/diff/40001/chrome/test/kasko/hang_...
File chrome/test/kasko/hang_watcher_integration_test.py (right):

https://codereview.chromium.org/1543803005/diff/40001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:8: This test ensures that
Kasko is able to detect when Chrome is hanged and to
On 2016/01/11 19:42:58, Sigurður Ásgeirsson wrote:
> is hanged -> hangs
> also I think you intend to name the hang watcher rather than Kasko here?

Done.

https://codereview.chromium.org/1543803005/diff/40001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:12: Note that this test only
works against non-component Release and Official builds
On 2016/01/12 19:42:15, chrisha wrote:
> On 2016/01/11 19:42:58, Sigurður Ásgeirsson wrote:
> > the bulk of this file wants to be reused rather than copied.
> 
> I've got a CL in progress which lifts all of the pieces to reusable components
> in a module. Maybe wait for that to land and build on top of it?
> 
> https://codereview.chromium.org/1582613002/

Done.

https://codereview.chromium.org/1543803005/diff/40001/components/browser_watc...
File components/browser_watcher/window_hang_monitor_win.cc (right):

https://codereview.chromium.org/1543803005/diff/40001/components/browser_watc...
components/browser_watcher/window_hang_monitor_win.cc:29: HWND
FindChromeMessageWindow(base::ProcessId pid) {
On 2016/01/11 19:42:59, Sigurður Ásgeirsson wrote:
> now that I think about it, I'm not sure this is "good enough". The problem is
> that this will find *A* message window, but I don't know that there's
precisely
> zero or one of those per chrome instance. The lifetime of other message
windows
> may or may not be appropriate for hang monitoring.

So I'm now also check that the name of the window is an existing path.

https://codereview.chromium.org/1543803005/diff/40001/components/browser_watc...
components/browser_watcher/window_hang_monitor_win.cc:34: if
(GetWindowClassName(candidate) == L"Chrome_MessageWindow" &&
On 2016/01/11 19:42:59, Sigurður Ásgeirsson wrote:
> doesn't matter a whole lot, but you can avoid a bunch of string copying here
by
> naming this function something like IsWindowClassName, and passing it a
> stringpiece.

Done.

[Sigurður Ásgeirsson, 2016-01-20 18:21:13]

very nice - lgtm for what it's worth, but please wait for Chris' comments as
well

https://codereview.chromium.org/1543803005/diff/60001/components/browser_watc...
File components/browser_watcher/window_hang_monitor_win.cc (right):

https://codereview.chromium.org/1543803005/diff/60001/components/browser_watc...
components/browser_watcher/window_hang_monitor_win.cc:28: bool
WindowNameIsExistingDirectory(HWND window) {
nice - I think this heuristic is fine.
Maybe leave a short comment noting that this could be improved by testing for a
valid profile in the directory or such?

https://codereview.chromium.org/1543803005/diff/60001/components/browser_watc...
File components/browser_watcher/window_hang_monitor_win_unittest.cc (right):

https://codereview.chromium.org/1543803005/diff/60001/components/browser_watc...
components/browser_watcher/window_hang_monitor_win_unittest.cc:92: class
MonitoredProcessClient {
wow - what a rigamarole to get some IPC going :/.

https://codereview.chromium.org/1543803005/diff/60001/components/browser_watc...
components/browser_watcher/window_hang_monitor_win_unittest.cc:404: HANDLE
read_pipe_;
do these perhaps want to be base::win::ScopedHandles?

[chrisha, 2016-01-20 22:20:31]

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/hang_...
File chrome/test/kasko/hang_watcher_integration_test.py (right):

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:22: ninja -C out\Release
chromedriver.exe
This may as well be ninja -C out\Release chrome.exe chromedriver.exe

Ah, you could fix this for the other 2 .py files while you're in here (they both
also need chromedriver.exe)

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:70: chrome =
kasko.process.ChromeInstance(options.chromedriver,
The whole body of this test is still the same as the kasko_integration_test.
Create a new module in the python library that accepts the URL to visit, the
timeout, and the keys to validate, and refactor both those tests to use the
common code?

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:91: 'ver',
You should be able to use ValidateCrashReport as is. The map doesn't define the
contents of the keys... it just ensures that they are defined. The 'value'
associated with each key is used as an additional error message, hopefully
providing context to whoever is running the test.

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:95: _LOGGER.info('Test passed
successfully!')
Ditto to adding this to the other couple tests... might be useful :)

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/py/ka...
File chrome/test/kasko/py/kasko/report.py (right):

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/py/ka...
chrome/test/kasko/py/kasko/report.py:38: def ValidateNonEmptyCrashKeys(report,
expected_keys):
You should be able to use the above validation logic without writing new logic.

[Patrick Monette, 2016-01-21 00:05:10]

chrisha@ Refactored my test and kasko_integration_test into a common module.
PTAL

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/hang_...
File chrome/test/kasko/hang_watcher_integration_test.py (right):

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:22: ninja -C out\Release
chromedriver.exe
On 2016/01/20 22:20:31, chrisha wrote:
> This may as well be ninja -C out\Release chrome.exe chromedriver.exe
> 
> Ah, you could fix this for the other 2 .py files while you're in here (they
both
> also need chromedriver.exe)

Done.

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:70: chrome =
kasko.process.ChromeInstance(options.chromedriver,
On 2016/01/20 22:20:31, chrisha wrote:
> The whole body of this test is still the same as the kasko_integration_test.
> Create a new module in the python library that accepts the URL to visit, the
> timeout, and the keys to validate, and refactor both those tests to use the
> common code?

Done.

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:91: 'ver',
On 2016/01/20 22:20:31, chrisha wrote:
> You should be able to use ValidateCrashReport as is. The map doesn't define
the
> contents of the keys... it just ensures that they are defined. The 'value'
> associated with each key is used as an additional error message, hopefully
> providing context to whoever is running the test.

Done.

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/hang_...
chrome/test/kasko/hang_watcher_integration_test.py:95: _LOGGER.info('Test passed
successfully!')
On 2016/01/20 22:20:31, chrisha wrote:
> Ditto to adding this to the other couple tests... might be useful :)

Done.

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/py/ka...
File chrome/test/kasko/py/kasko/report.py (right):

https://codereview.chromium.org/1543803005/diff/60001/chrome/test/kasko/py/ka...
chrome/test/kasko/py/kasko/report.py:38: def ValidateNonEmptyCrashKeys(report,
expected_keys):
On 2016/01/20 22:20:31, chrisha wrote:
> You should be able to use the above validation logic without writing new
logic.

Done.

https://codereview.chromium.org/1543803005/diff/60001/components/browser_watc...
File components/browser_watcher/window_hang_monitor_win.cc (right):

https://codereview.chromium.org/1543803005/diff/60001/components/browser_watc...
components/browser_watcher/window_hang_monitor_win.cc:28: bool
WindowNameIsExistingDirectory(HWND window) {
On 2016/01/20 18:21:13, Sigurður Ásgeirsson wrote:
> nice - I think this heuristic is fine.
> Maybe leave a short comment noting that this could be improved by testing for
a
> valid profile in the directory or such?

Done.

https://codereview.chromium.org/1543803005/diff/60001/components/browser_watc...
File components/browser_watcher/window_hang_monitor_win_unittest.cc (right):

https://codereview.chromium.org/1543803005/diff/60001/components/browser_watc...
components/browser_watcher/window_hang_monitor_win_unittest.cc:92: class
MonitoredProcessClient {
On 2016/01/20 18:21:13, Sigurður Ásgeirsson wrote:
> wow - what a rigamarole to get some IPC going :/.

Haha yes.

https://codereview.chromium.org/1543803005/diff/60001/components/browser_watc...
components/browser_watcher/window_hang_monitor_win_unittest.cc:404: HANDLE
read_pipe_;
On 2016/01/20 18:21:13, Sigurður Ásgeirsson wrote:
> do these perhaps want to be base::win::ScopedHandles?

Done.

[chrisha, 2016-01-21 18:17:41]

Thanks for the cleanup! This lgtm with nits.

https://codereview.chromium.org/1543803005/diff/80001/chrome/test/kasko/kasko...
File chrome/test/kasko/kasko_integration_test.py (right):

https://codereview.chromium.org/1543803005/diff/80001/chrome/test/kasko/kasko...
chrome/test/kasko/kasko_integration_test.py:47:
{'kasko-set-crash-key-value-impl': 'SetCrashKeyValueImpl'})
Much cleaner, thanks!

https://codereview.chromium.org/1543803005/diff/80001/chrome/test/kasko/py/ka...
File chrome/test/kasko/py/kasko/integration_test.py (right):

https://codereview.chromium.org/1543803005/diff/80001/chrome/test/kasko/py/ka...
chrome/test/kasko/py/kasko/integration_test.py:21: Launches both test server and
a Chrome instance and then navigates
Indent -3.

https://codereview.chromium.org/1543803005/diff/80001/chrome/test/kasko/py/ka...
chrome/test/kasko/py/kasko/integration_test.py:24: verified against expected
crash keys.
Worth describing the arguments. Standard format is:

Args:
  url The URL that the browser will be navigated to in order to 
    cause a crash.
  timeout The time, in seconds, in which the crash is expected to 
    be processed.
  ...

[Patrick Monette, 2016-01-21 19:54:02]

Hey brettw@ needs owners LGTM for
build/common.gypi
chrome/app/main_dll_loader_win.cc
chrome/browser/extensions/extension_tab_util.cc
and
content/*
Thanks.

https://codereview.chromium.org/1543803005/diff/80001/chrome/test/kasko/py/ka...
File chrome/test/kasko/py/kasko/integration_test.py (right):

https://codereview.chromium.org/1543803005/diff/80001/chrome/test/kasko/py/ka...
chrome/test/kasko/py/kasko/integration_test.py:21: Launches both test server and
a Chrome instance and then navigates
On 2016/01/21 18:17:41, chrisha wrote:
> Indent -3.

Done.

https://codereview.chromium.org/1543803005/diff/80001/chrome/test/kasko/py/ka...
chrome/test/kasko/py/kasko/integration_test.py:24: verified against expected
crash keys.
On 2016/01/21 18:17:41, chrisha wrote:
> Worth describing the arguments. Standard format is:
> 
> Args:
>   url The URL that the browser will be navigated to in order to 
>     cause a crash.
>   timeout The time, in seconds, in which the crash is expected to 
>     be processed.
>   ...
>   

Done.

[Patrick Monette, 2016-01-21 19:55:01]

pmonette@chromium.org changed reviewers:
+ brettw@chromium.org

[Patrick Monette, 2016-01-21 19:55:01]

brettw@ Whoops forgot to add you as a reviewer. Look at my last message.

[Patrick Monette, 2016-01-26 18:40:57]

pmonette@chromium.org changed reviewers:
- brettw@chromium.org

[Patrick Monette, 2016-01-26 18:42:18]

pmonette@chromium.org changed reviewers:
+ jam@chromium.org

[Patrick Monette, 2016-01-26 18:42:19]

jam@ Need review for
build/common.gypi
chrome/app/main_dll_loader_win.cc
chrome/browser/extensions/extension_tab_util.cc
content/browser/frame_host/debug_urls.cc
content/public/common/url_constants.h
content/public/common/url_constants.cc

Mainly adding a debug url.

[jam, 2016-01-26 23:08:36]

https://codereview.chromium.org/1543803005/diff/100001/chrome/app/main_dll_lo...
File chrome/app/main_dll_loader_win.cc (left):

https://codereview.chromium.org/1543803005/diff/100001/chrome/app/main_dll_lo...
chrome/app/main_dll_loader_win.cc:231: base::FilePath
default_user_data_directory;
why is this code removed?

https://codereview.chromium.org/1543803005/diff/100001/content/public/common/...
File content/public/common/url_constants.cc (right):

https://codereview.chromium.org/1543803005/diff/100001/content/public/common/...
content/public/common/url_constants.cc:44: const char
kChromeUIDelayedBrowserUIHang[] = "chrome://delayeduithreadhang";
this is just for a test in the chrome layer, and it can be implemented in
chrome, so move it there.

[Patrick Monette, 2016-01-27 17:52:03]

jam@ I have one question for you

https://codereview.chromium.org/1543803005/diff/100001/chrome/app/main_dll_lo...
File chrome/app/main_dll_loader_win.cc (left):

https://codereview.chromium.org/1543803005/diff/100001/chrome/app/main_dll_lo...
chrome/app/main_dll_loader_win.cc:231: base::FilePath
default_user_data_directory;
On 2016/01/26 23:08:35, jam wrote:
> why is this code removed?

The user data directory was used by the hang watcher to find the Chrome message
window to ping. Since this value was always equal to chrome::DIR_USER_DATA, this
meant that the hang watcher couldn't work with different user directories (like
the test environment who creates a temporary user data dir).

Beside, the watcher can find it on its own using the window class name so I went
for this solution.

https://codereview.chromium.org/1543803005/diff/100001/content/public/common/...
File content/public/common/url_constants.cc (right):

https://codereview.chromium.org/1543803005/diff/100001/content/public/common/...
content/public/common/url_constants.cc:44: const char
kChromeUIDelayedBrowserUIHang[] = "chrome://delayeduithreadhang";
On 2016/01/26 23:08:35, jam wrote:
> this is just for a test in the chrome layer, and it can be implemented in
> chrome, so move it there.

Do you have a suggestion for it?
I am not finding something similar to HandleDebugURL() in the chrome layer.

[jam, 2016-01-27 23:26:19]

btw just curious how long we expect kasko to stay? my understanding was that
crashpad will replace breakpad + kasko right?

https://codereview.chromium.org/1543803005/diff/100001/content/public/common/...
File content/public/common/url_constants.cc (right):

https://codereview.chromium.org/1543803005/diff/100001/content/public/common/...
content/public/common/url_constants.cc:44: const char
kChromeUIDelayedBrowserUIHang[] = "chrome://delayeduithreadhang";
On 2016/01/27 17:52:03, Patrick Monette wrote:
> On 2016/01/26 23:08:35, jam wrote:
> > this is just for a test in the chrome layer, and it can be implemented in
> > chrome, so move it there.
> 
> Do you have a suggestion for it?
> I am not finding something similar to HandleDebugURL() in the chrome layer.

oh, you're right, it's not easy doing that now. ok ignore my comment then.

will there be a bug filed to remove this functionality once kasko is removed?

[Patrick Monette, 2016-01-27 23:34:53]

On 2016/01/27 23:26:19, jam wrote:
> btw just curious how long we expect kasko to stay? my understanding was that
> crashpad will replace breakpad + kasko right?
> 
>
https://codereview.chromium.org/1543803005/diff/100001/content/public/common/...
> File content/public/common/url_constants.cc (right):
> 
>
https://codereview.chromium.org/1543803005/diff/100001/content/public/common/...
> content/public/common/url_constants.cc:44: const char
> kChromeUIDelayedBrowserUIHang[] = "chrome://delayeduithreadhang";
> On 2016/01/27 17:52:03, Patrick Monette wrote:
> > On 2016/01/26 23:08:35, jam wrote:
> > > this is just for a test in the chrome layer, and it can be implemented in
> > > chrome, so move it there.
> > 
> > Do you have a suggestion for it?
> > I am not finding something similar to HandleDebugURL() in the chrome layer.
> 
> oh, you're right, it's not easy doing that now. ok ignore my comment then.
> 
> will there be a bug filed to remove this functionality once kasko is removed?

The hang detector is independent of the crash reporter and when we switch out
Kasko for Crashpad, this hang detection capability will still exist. It will
just use Crashpad to generate the crash report.

The removal of this functionality is then tied to when we won't need the hang
watcher in Chrome. I can fill a bug for this.

[Patrick Monette, 2016-01-28 00:03:02]

On 2016/01/27 23:34:53, Patrick Monette wrote:
> On 2016/01/27 23:26:19, jam wrote:
> > btw just curious how long we expect kasko to stay? my understanding was that
> > crashpad will replace breakpad + kasko right?
> > 
> >
>
https://codereview.chromium.org/1543803005/diff/100001/content/public/common/...
> > File content/public/common/url_constants.cc (right):
> > 
> >
>
https://codereview.chromium.org/1543803005/diff/100001/content/public/common/...
> > content/public/common/url_constants.cc:44: const char
> > kChromeUIDelayedBrowserUIHang[] = "chrome://delayeduithreadhang";
> > On 2016/01/27 17:52:03, Patrick Monette wrote:
> > > On 2016/01/26 23:08:35, jam wrote:
> > > > this is just for a test in the chrome layer, and it can be implemented
in
> > > > chrome, so move it there.
> > > 
> > > Do you have a suggestion for it?
> > > I am not finding something similar to HandleDebugURL() in the chrome
layer.
> > 
> > oh, you're right, it's not easy doing that now. ok ignore my comment then.
> > 
> > will there be a bug filed to remove this functionality once kasko is
removed?
> 
> The hang detector is independent of the crash reporter and when we switch out
> Kasko for Crashpad, this hang detection capability will still exist. It will
> just use Crashpad to generate the crash report.
> 
> The removal of this functionality is then tied to when we won't need the hang
> watcher in Chrome. I can fill a bug for this.

Do you want me to do so?

[Patrick Monette, 2016-01-29 18:12:52]

jam: ping

[Patrick Monette, 2016-01-29 18:12:53]

jam: ping

[jam, 2016-01-29 18:15:41]

sorry for the delay, I missed this.

lgtm.

(in the future if i dont reply within a few hours, feel free to IM me)

[Patrick Monette, 2016-01-29 18:28:17]

Description was changed from

==========
Added an integration test for kasko hang reports
==========

to

==========
Added an integration test for kasko hang reports
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Patrick Monette, 2016-01-29 18:29:23]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-01-29 18:29:24]

The patchset sent to the CQ was uploaded after l-g-t-m from siggi@chromium.org,
chrisha@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1543803005/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2016-01-29 18:30:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1543803005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1543803005/120001

[commit-bot: I haz the power, 2016-01-29 18:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 18:43:54]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Patrick Monette, 2016-01-29 19:06:51]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-01-29 19:06:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrisha@chromium.org, jam@chromium.org, siggi@chromium.org
Link to the patchset: https://codereview.chromium.org/1543803005/#ps140001
(title: "Set executable bit for python scripts")

[commit-bot: I haz the power, 2016-01-29 19:07:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1543803005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1543803005/140001

[Patrick Monette, 2016-01-29 22:13:30]

Description was changed from

==========
Added an integration test for kasko hang reports
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Added an integration test for kasko hang reports
==========

[Patrick Monette, 2016-01-29 22:13:35]

The CQ bit was unchecked by pmonette@chromium.org

[Patrick Monette, 2016-01-29 22:13:41]

The CQ bit was checked by pmonette@chromium.org

[commit-bot: I haz the power, 2016-01-29 22:15:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1543803005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1543803005/140001

[commit-bot: I haz the power, 2016-01-29 22:24:44]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-01-29 22:26:14]

Description was changed from

==========
Added an integration test for kasko hang reports
==========

to

==========
Added an integration test for kasko hang reports

Committed: https://crrev.com/3955a4ff6fb5b66408cf3748c9dcd4bd22885c80
Cr-Commit-Position: refs/heads/master@{#372442}
==========

[commit-bot: I haz the power, 2016-01-29 22:26:15]

Patchset 7 (id:??) landed as
https://crrev.com/3955a4ff6fb5b66408cf3748c9dcd4bd22885c80
Cr-Commit-Position: refs/heads/master@{#372442}