Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Issue 1543803002: Revert of [proxies] Better print for proxies in d8 (Closed)

Created:
5 years ago by Camillo Bruni
Modified:
5 years ago
Reviewers:
neis, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [proxies] Better print for proxies in d8 (patchset #6 id:100001 of https://codereview.chromium.org/1530293004/ ) Reason for revert: needs --allow-natives-syntax Original issue's description: > [proxies] Better print for proxies in d8 > > Function proxies would not be printed so far since they ended up in Function.prototype.toString which only works with Function as a receiver but no Proxy. Additionally added support for more gracefully dealing with recursive __proto__ structures introduced by proxies. > > BUG=v8:1543 > LOG=n > > Committed: https://crrev.com/8bfb7189a3472bc9d0820a1bd4534eaaf78ff847 > Cr-Commit-Position: refs/heads/master@{#32985} TBR=neis@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1543 Committed: https://crrev.com/f4cd91c75f967da4f9cb3d368543ef1e77df4965 Cr-Commit-Position: refs/heads/master@{#33001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -96 lines) Patch
M src/d8.js View 2 chunks +31 lines, -50 lines 0 comments Download
M src/js/collection.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/json.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/macros.py View 1 chunk +23 lines, -24 lines 0 comments Download
M src/js/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/object-observe.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/proxy.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/v8natives.js View 3 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/runtime/runtime-proxy.cc View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Camillo Bruni
Created Revert of [proxies] Better print for proxies in d8
5 years ago (2015-12-22 08:57:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543803002/1
5 years ago (2015-12-22 08:57:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 08:57:35 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-22 08:58:26 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4cd91c75f967da4f9cb3d368543ef1e77df4965
Cr-Commit-Position: refs/heads/master@{#33001}

Powered by Google App Engine
This is Rietveld 408576698