net/quic/quic_framer_test.cc - Issue 1543703002: Drop packets which are larger than kMaxPacketSize, instead of closing the connection with QUIC_PACK…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_framer_test.cc

Issue 1543703002: Drop packets which are larger than kMaxPacketSize, instead of closing the connection with QUIC_PACK… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@110286048

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_framer_test.cc

diff --git a/net/quic/quic_framer_test.cc b/net/quic/quic_framer_test.cc

index 7fcef7a0893bbbc891ddf2aeb991780a900601d7..176d4f52d577392ffa266c0c3196810939e95257 100644

--- a/net/quic/quic_framer_test.cc

+++ b/net/quic/quic_framer_test.cc

@@ -637,7 +637,7 @@ TEST_P(QuicFramerTest, LargePacket) {

// clang-format on

QuicEncryptedPacket encrypted(AsChars(packet), arraysize(packet), false);

- EXPECT_FALSE(framer_.ProcessPacket(encrypted));

+ EXPECT_DFATAL(framer_.ProcessPacket(encrypted), "Packet too large:1");

ASSERT_TRUE(visitor_.header_.get());

// Make sure we've parsed the packet header, so we can send an error.

« no previous file with comments | « net/quic/quic_framer.cc ('k') | net/quic/quic_protocol.h » ('j') | no next file with comments »