Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: content/browser/media/webrtc_media_recorder_browsertest.cc

Issue 1543673002: MediaRecorder: make MediaRecorderHandler a MediaStreamObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added content_browsertests for Error Event firing when Track added/removed to MS Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/web_test_delegate.h ('k') | content/public/renderer/media_stream_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/webrtc_media_recorder_browsertest.cc
diff --git a/content/browser/media/webrtc_media_recorder_browsertest.cc b/content/browser/media/webrtc_media_recorder_browsertest.cc
index 8af014133393286195a77bd9c677803d5a25fdf9..e792c1db8a40c5c8af930b1f02a6897de055eddc 100644
--- a/content/browser/media/webrtc_media_recorder_browsertest.cc
+++ b/content/browser/media/webrtc_media_recorder_browsertest.cc
@@ -28,7 +28,7 @@ static const char kMediaRecorderHtmlFile[] = "/media/mediarecorder_test.html";
} // namespace
namespace content {
-// This class tests the recording of a media stream.
+// This class tests the recording of a Media Stream.
class MAYBE_WebRtcMediaRecorderTest : public WebRtcContentBrowserTest {
public:
MAYBE_WebRtcMediaRecorderTest() {}
@@ -77,7 +77,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest, MediaRecorderResume) {
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MediaRecorderNoResumeWhenRecorderInactive) {
MakeTypicalCall("testNoResumeWhileRecorderInactive();",
- kMediaRecorderHtmlFile);
+ kMediaRecorderHtmlFile);
}
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
@@ -98,7 +98,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MediaRecorderPausePreventsDataavailableFromBeingFired) {
MakeTypicalCall("testPausePreventsDataavailableFromBeingFired();",
- kMediaRecorderHtmlFile);
+ kMediaRecorderHtmlFile);
}
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
@@ -113,26 +113,37 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MediaRecorderIllegalStopThrowsDOMError) {
- MakeTypicalCall("testIllegalStopThrowsDOMError();",
- kMediaRecorderHtmlFile);
+ MakeTypicalCall("testIllegalStopThrowsDOMError();", kMediaRecorderHtmlFile);
}
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MediaRecorderIllegalStartWhileRecordingThrowsDOMError) {
MakeTypicalCall("testIllegalStartInRecordingStateThrowsDOMError();",
- kMediaRecorderHtmlFile);
+ kMediaRecorderHtmlFile);
}
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MediaRecorderIllegalStartWhilePausedThrowsDOMError) {
MakeTypicalCall("testIllegalStartInPausedStateThrowsDOMError();",
- kMediaRecorderHtmlFile);
+ kMediaRecorderHtmlFile);
}
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MediaRecorderIllegalRequestDataThrowsDOMError) {
MakeTypicalCall("testIllegalRequestDataThrowsDOMError();",
- kMediaRecorderHtmlFile);
+ kMediaRecorderHtmlFile);
+}
+
+IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
+ AddingTrackToMediaStreamFiresErrorEvent) {
+ MakeTypicalCall("testAddingTrackToMediaStreamFiresErrorEvent();",
+ kMediaRecorderHtmlFile);
+}
+
+IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
+ RemovingTrackFromMediaStreamFiresErrorEvent) {
+ MakeTypicalCall("testRemovingTrackFromMediaStreamFiresErrorEvent();",
+ kMediaRecorderHtmlFile);
}
} // namespace content
« no previous file with comments | « components/test_runner/web_test_delegate.h ('k') | content/public/renderer/media_stream_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698