MediaRecorder: make MediaRecorderHandler a MediaStreamObserver

components/test_runner/mock_web_user_media_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/test_runner/mock_web_user_media_client.h"
 
 #include "base/logging.h"
 #include "base/macros.h"
 #include "components/test_runner/mock_constraints.h"
 #include "components/test_runner/web_test_delegate.h"
@@ skipping 145 matching lines @@
     if (!constraints.isNull() &&
         !MockConstraints::VerifyConstraints(constraints, &failed_constraint)) {
       delegate_->PostTask(new UserMediaRequestConstraintFailedTask(
           this, request, failed_constraint));
       return;
     }
 
     WebMediaStream stream;
     stream.initialize(WebVector<WebMediaStreamTrack>(),
                       WebVector<WebMediaStreamTrack>());
-    stream.setExtraData(new MockExtraData());
+    delegate_->AddMediaStream(&stream);

[perkj_chrome, 2016/01/07 09:18:00]

this seems wrong. Why not just do stream.setExtraData(new
content::MediaStream()) if you need this.

[mcasas, 2016/01/08 00:14:12]

The gist of this is that test_runner cannot depend on 
content/ [1]. 

(Instead, the idea is to add stuff to a WebTestDelegate  
and implement that accordingly).


[1] https://codereview.chromium.org/1371373002/#msg37

[perkj_chrome, 2016/01/08 07:54:50]

I see. So MockWebUserMediaClient does not actually mock the real implementation
that well.
However, it feels wrong to add a public API in content/public/media_stream that
should never be called by anyone but the layout tests. It should never be called
since content::MediaStream  is created from  MediaStreamCenter if the
mediastream is created from JS.  If the stream has been created in
user_media_client, user_media_client creates content::MediaStream.

 
     if (request.audio() &&
         !delegate_->AddMediaStreamAudioSourceAndTrack(&stream)) {
       WebMediaStreamSource source;
       source.initialize("MockAudioDevice#1",
                         WebMediaStreamSource::TypeAudio,
                         "Mock audio device",
                         false /* remote */,
                         true /* readonly */);
       WebMediaStreamTrack web_track;
@@ skipping 90 matching lines @@
   sources[i].initialize(WebString::fromUTF8(test_sources[i].id),
                         test_sources[i].kind,
                         WebString::fromUTF8(test_sources[i].label),
                         test_sources[i].facing);
   }
 
   delegate_->PostTask(new SourcesRequestTask(this, request, sources));
 }
 
 }  // namespace test_runner