Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1543613002: Revert of MIPS64: Fix trunc_l_[s,d] in simulator. (Closed)

Created:
5 years ago by akos.palfi.imgtec
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of MIPS64: Fix trunc_l_[s,d] in simulator. (patchset #1 id:1 of https://codereview.chromium.org/1539763003/ ) Reason for revert: Causes failures in r6 mode. Original issue's description: > MIPS64: Fix trunc_l_[s,d] in simulator. > > The trunc_l_[s,d] instructions incorrectly returns success when the input is INT64_MAX. > > TEST=test-run-machops/RunTryTruncateFloat32ToInt64WithCheck,test-run-machops/RunTryTruncateFloat64ToInt64WithCheck > BUG= > > Committed: https://crrev.com/53a0cc846661c65b4b1711f67642677d8da69119 > Cr-Commit-Position: refs/heads/master@{#32968} TBR=paul.lind@imgtec.com,balazs.kilvady@imgtec.com,ahaas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/3e27f6d55e6f181a685204ac69ab9fe83f2ffe76 Cr-Commit-Position: refs/heads/master@{#32989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/mips/simulator-mips.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
akos.palfi.imgtec
Created Revert of MIPS64: Fix trunc_l_[s,d] in simulator.
5 years ago (2015-12-21 16:20:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543613002/1
5 years ago (2015-12-21 16:20:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 16:20:56 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-21 16:21:20 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e27f6d55e6f181a685204ac69ab9fe83f2ffe76
Cr-Commit-Position: refs/heads/master@{#32989}

Powered by Google App Engine
This is Rietveld 408576698