third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp - Issue 1543593002: Forward fill and stroke styles from 2d canvas to canvas filters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp

Issue 1543593002: Forward fill and stroke styles from 2d canvas to canvas filters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove PaintFilterEffect::affectsTransparentPixels Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.h ('k') | third_party/WebKit/Source/core/paint/FilterEffectBuilder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp b/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp

index e07d7ef51e8b532b2ff308e0f07312104f9aa599..1f2ea901cdcb66dc47d30e9674c4baa5d2e10fc9 100644

--- a/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp

@@ -69,7 +69,7 @@ void ReferenceFilterBuilder::clearDocumentResourceReference(const FilterOperatio

}

#endif

-PassRefPtrWillBeRawPtr<Filter> ReferenceFilterBuilder::build(float zoom, Element* element, FilterEffect* previousEffect, const ReferenceFilterOperation& filterOperation)

+PassRefPtrWillBeRawPtr<Filter> ReferenceFilterBuilder::build(float zoom, Element* element, FilterEffect* previousEffect, const ReferenceFilterOperation& filterOperation, const SkPaint* fillPaint, const SkPaint* strokePaint)

{

TreeScope* treeScope = &element->treeScope();

@@ -112,7 +112,7 @@ PassRefPtrWillBeRawPtr<Filter> ReferenceFilterBuilder::build(float zoom, Element

if (!previousEffect)

previousEffect = result->sourceGraphic();

- SVGFilterBuilder builder(previousEffect);

+ SVGFilterBuilder builder(previousEffect, nullptr, fillPaint, strokePaint);

builder.buildGraph(result.get(), filterElement, referenceBox);

result->setLastEffect(builder.lastEffect());