Forward fill and stroke styles from 2d canvas to canvas filters

third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/canvas2d/CanvasRenderingContext2DState.h"
 
 #include "core/css/CSSFontSelector.h"
 #include "core/css/resolver/FilterOperationResolver.h"
 #include "core/css/resolver/StyleBuilder.h"
 #include "core/css/resolver/StyleResolverState.h"
@@ skipping 336 matching lines @@
         return nullptr;
 
     if (!m_resolvedFilter) {
         RefPtr<ComputedStyle> filterStyle = ComputedStyle::create();
         // Must set font in case the filter uses any font-relative units (em, ex)
         filterStyle->setFont(font);
 
         StyleResolverState resolverState(styleResolutionHost->document(), styleResolutionHost, filterStyle.get());
         resolverState.setStyle(filterStyle);
 
-        // TODO(junov): crbug.com/502877 Feed m_fillStyle and m_strokeStyle into FillPaint and
-        // StrokePaint respectively for filters that reference SVG.
         StyleBuilder::applyProperty(CSSPropertyWebkitFilter, resolverState, m_filterValue.get());
         RefPtrWillBeRawPtr<FilterEffectBuilder> filterEffectBuilder = FilterEffectBuilder::create();
+        SkPaint fillPaint;

[Justin Novosad, 2016/01/11 19:52:42]

Is there a reason why we need to create a new paint rather than use m_fillPaint
and m_strokePaint? Assuming there is a good reason, could you put that reason in
a comment, and use a name that is more specific, like fillPaintForFilter to
avoid reader's confusion with m_fillPaint.  Same thing for strokePaint.

[ajuma, 2016/01/11 21:33:08]

Added a comment and changed the variable names.

+        SkPaint strokePaint;
+        m_fillStyle->applyToPaint(fillPaint);
+        m_strokeStyle->applyToPaint(strokePaint);
+        fillPaint.setColor(m_fillStyle->paintColor());
+        strokePaint.setColor(m_strokeStyle->paintColor());
         const double effectiveZoom = 1.0; // Deliberately ignore zoom on the canvas element
-        filterEffectBuilder->build(styleResolutionHost, filterStyle->filter(), effectiveZoom);
+        filterEffectBuilder->build(styleResolutionHost, filterStyle->filter(), effectiveZoom, &fillPaint, &strokePaint);
 
         SkiaImageFilterBuilder imageFilterBuilder;
         RefPtrWillBeRawPtr<FilterEffect> lastEffect = filterEffectBuilder->lastEffect();
         m_resolvedFilter = imageFilterBuilder.build(lastEffect.get(), ColorSpaceDeviceRGB);
     }
 
     return m_resolvedFilter.get();
 }
 
 SkDrawLooper* CanvasRenderingContext2DState::emptyDrawLooper() const
@@ skipping 209 matching lines @@
         paint->setLooper(0);
         paint->setImageFilter(shadowAndForegroundImageFilter());
         return paint;
     }
     paint->setLooper(shadowAndForegroundDrawLooper());
     paint->setImageFilter(0);
     return paint;
 }
 
 } // blink