Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 1543553002: [proxies] Adapt and reenable remaining tests in proxies.js (Closed)

Created:
5 years ago by neis
Modified:
4 years, 11 months ago
Reviewers:
Camillo Bruni, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Adapt and reenable remaining tests in proxies.js R=cbruni@chromium.org BUG= Committed: https://crrev.com/d006f617d4cbfbcdc545411bbb4127fa53fc47bc Cr-Commit-Position: refs/heads/master@{#33180}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M test/mjsunit/harmony/proxies.js View 1 4 chunks +8 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
neis
5 years ago (2015-12-21 12:13:59 UTC) #1
Camillo Bruni
lgtm with nit https://codereview.chromium.org/1543553002/diff/1/test/mjsunit/harmony/proxies.js File test/mjsunit/harmony/proxies.js (right): https://codereview.chromium.org/1543553002/diff/1/test/mjsunit/harmony/proxies.js#newcode1372 test/mjsunit/harmony/proxies.js:1372: assertThrows(() => Object.prototype.toString.call(p)) Could you check ...
5 years ago (2015-12-21 12:50:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543553002/20001
4 years, 11 months ago (2016-01-07 14:57:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9522)
4 years, 11 months ago (2016-01-07 15:00:07 UTC) #7
rossberg
lgtm
4 years, 11 months ago (2016-01-08 14:54:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543553002/20001
4 years, 11 months ago (2016-01-08 14:55:06 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-08 14:56:39 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 14:57:08 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d006f617d4cbfbcdc545411bbb4127fa53fc47bc
Cr-Commit-Position: refs/heads/master@{#33180}

Powered by Google App Engine
This is Rietveld 408576698