Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1543533002: Restore non-static CLD data functionality. (Closed)

Created:
5 years ago by Andrew Hayden (chromium.org)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore non-static CLD data functionality. When the translate client was refactored to be managed by the translate driver and to use a RenderFrameHost instead of a RenderViewHost, it accidentally broke non-static CLD initialization because the IPC messages being received by the translate driver were not being passed into the CLD data provider. This change moves the relevant code from the translate client into the translate driver and restores functionality. BUG=571016 TBR=droger@chromium.org Committed: https://crrev.com/527353a3407034ed8a57e06a2eb722caa2d968c1 Cr-Commit-Position: refs/heads/master@{#369396}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M chrome/browser/translate/chrome_translate_client.h View 1 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/translate/chrome_translate_client.cc View 1 2 3 chunks +3 lines, -9 lines 0 comments Download
M components/translate/content/browser/content_translate_driver.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M components/translate/content/browser/content_translate_driver.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Andrew Hayden (chromium.org)
toyoshim@, would you mind taking a look? It looks like droger@ is unavailable for the ...
5 years ago (2015-12-21 11:04:18 UTC) #3
Andrew Hayden (chromium.org)
Rebased onto latest master, PTAL.
4 years, 11 months ago (2015-12-29 11:35:07 UTC) #4
Takashi Toyoshima
I'm back from vacation today, and will be able to take a look tomorrow.
4 years, 11 months ago (2016-01-12 10:22:59 UTC) #5
Takashi Toyoshima
lgtm
4 years, 11 months ago (2016-01-13 11:20:09 UTC) #6
Andrew Hayden (chromium.org)
Thanks, Takashi. I'm rebasing and re-running the trybots and will get this submitted.
4 years, 11 months ago (2016-01-13 16:14:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543533002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543533002/40001
4 years, 11 months ago (2016-01-14 12:07:35 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-14 12:11:39 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/527353a3407034ed8a57e06a2eb722caa2d968c1 Cr-Commit-Position: refs/heads/master@{#369396}
4 years, 11 months ago (2016-01-14 12:13:09 UTC) #14
droger
4 years, 11 months ago (2016-01-14 12:23:52 UTC) #16
Message was sent while issue was closed.
Sorry I missed this CL, LGTM!

Powered by Google App Engine
This is Rietveld 408576698