Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1543483002: gn: leave PKG_CONFIG_PATH untouched when not using a sysroot (Closed)

Created:
5 years ago by Mostyn Bramley-Moore
Modified:
4 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: leave PKG_CONFIG_PATH untouched when not using a sysroot This makes cross-compilation possible when not using a sysroot. Committed: https://crrev.com/c61271cf022bfb412db3e53ce8bbc5d8c2c1a873 Cr-Commit-Position: refs/heads/master@{#367906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M build/config/linux/pkg-config.py View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Mostyn Bramley-Moore
@brettw: please take a look at this small adjustment, which makes it possible to cross-compile ...
5 years ago (2015-12-21 09:55:02 UTC) #3
brettw
lgtm
4 years, 11 months ago (2016-01-06 19:07:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543483002/1
4 years, 11 months ago (2016-01-06 20:35:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 21:07:28 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 21:09:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c61271cf022bfb412db3e53ce8bbc5d8c2c1a873
Cr-Commit-Position: refs/heads/master@{#367906}

Powered by Google App Engine
This is Rietveld 408576698