Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1543403002: Create a section of the summary for public namespace information. (Closed)

Created:
4 years, 12 months ago by Paul Berry
Modified:
4 years, 12 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create a section of the summary for public namespace information. This will make it easier to re-link summaries when a file changes, since all the information that is needed from imported libraries will be in the "public namespace" section of the summary. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ac37dc71d068acc1576ab6642b5d0000b948ffd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -76 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 6 chunks +123 lines, -25 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 5 chunks +11 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +44 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 23 chunks +122 lines, -24 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 3 chunks +56 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 12 months ago (2015-12-24 22:46:15 UTC) #2
scheglov
LGTM
4 years, 12 months ago (2015-12-24 23:20:04 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as ac37dc71d068acc1576ab6642b5d0000b948ffd9 (presubmit successful).
4 years, 12 months ago (2015-12-24 23:55:21 UTC) #5
Brian Wilkerson
4 years, 12 months ago (2015-12-27 16:46:20 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698