Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm

Issue 1543393002: Switch to standard integer types in chrome/browser/ui/cocoa/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm
diff --git a/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm b/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm
index bbb0dc4fa0e6f4a78ce3f7834813ea183ebdfbcf..c2dac239c7ccf21b53da0ecd2dbf351078a16447 100644
--- a/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm
+++ b/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm
@@ -4,10 +4,13 @@
#import "chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h"
+#include <stdint.h>
+
#include <utility>
#include "base/mac/scoped_cftyperef.h"
#include "base/mac/scoped_nsobject.h"
+#include "base/macros.h"
#include "chrome/browser/devtools/devtools_window.h"
#import "chrome/browser/themes/theme_properties.h"
#import "chrome/browser/themes/theme_service.h"
@@ -338,8 +341,8 @@ class FullscreenObserver : public WebContentsObserver {
// TODO(miu): This is basically media::ComputeLetterboxRegion(), and it
// looks like others have written this code elsewhere. Let's consolidate
// into a shared function ui/gfx/geometry or around there.
- const int64 x = static_cast<int64>(captureSize.width()) * rect.height();
- const int64 y = static_cast<int64>(captureSize.height()) * rect.width();
+ const int64_t x = static_cast<int64_t>(captureSize.width()) * rect.height();
+ const int64_t y = static_cast<int64_t>(captureSize.height()) * rect.width();
if (y < x) {
rect.ClampToCenteredSize(gfx::Size(
rect.width(), static_cast<int>(y / captureSize.width())));

Powered by Google App Engine
This is Rietveld 408576698