chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_unittest.mm - Issue 1543393002: Switch to standard integer types in chrome/browser/ui/cocoa/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_unittest.mm

Issue 1543393002: Switch to standard integer types in chrome/browser/ui/cocoa/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm ('k') | chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac_unittest.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 #include "base/macros.h"

5 #include "base/strings/string_number_conversions.h"	6 #include "base/strings/string_number_conversions.h"

6 #include "base/strings/utf_string_conversions.h"	7 #include "base/strings/utf_string_conversions.h"

7 #include "chrome/browser/media_galleries/media_galleries_dialog_controller_mock. h"	8 #include "chrome/browser/media_galleries/media_galleries_dialog_controller_mock. h"

8 #include "chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h"	9 #include "chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h"

9 #include "components/storage_monitor/storage_info.h"	10 #include "components/storage_monitor/storage_info.h"

10 #include "extensions/common/extension.h"	11 #include "extensions/common/extension.h"

11 #include "extensions/common/test_util.h"	12 #include "extensions/common/test_util.h"

12 #include "testing/gtest/include/gtest/gtest.h"	13 #include "testing/gtest/include/gtest/gtest.h"

13	14

14 using ::testing::_;	15 using ::testing::_;

(...skipping 185 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
200 // Remove a gallery.	201 // Remove a gallery.

201 attached_permissions.erase(attached_permissions.begin());	202 attached_permissions.erase(attached_permissions.begin());

202 GetOrCreateDialog()->UpdateGalleries();	203 GetOrCreateDialog()->UpdateGalleries();

203 EXPECT_EQ(1U, [[GetOrCreateDialog()->checkbox_container_ subviews] count]);	204 EXPECT_EQ(1U, [[GetOrCreateDialog()->checkbox_container_ subviews] count]);

204	205

205 // The checkbox container should be shorter.	206 // The checkbox container should be shorter.

206 CGFloat new_container_height =	207 CGFloat new_container_height =

207 NSHeight([GetOrCreateDialog()->checkbox_container_ frame]);	208 NSHeight([GetOrCreateDialog()->checkbox_container_ frame]);

208 EXPECT_LT(new_container_height, old_container_height);	209 EXPECT_LT(new_container_height, old_container_height);

209 }	210 }

OLD	NEW