Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

Issue 1543393002: Switch to standard integer types in chrome/browser/ui/cocoa/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 #include <stddef.h>
7 #include <stdint.h>
6 8
7 #include "base/basictypes.h"
8 #include "base/command_line.h" 9 #include "base/command_line.h"
9 #include "base/mac/mac_util.h" 10 #include "base/mac/mac_util.h"
10 #include "base/mac/scoped_nsobject.h" 11 #include "base/mac/scoped_nsobject.h"
12 #include "base/macros.h"
11 #include "base/run_loop.h" 13 #include "base/run_loop.h"
12 #include "base/strings/string16.h" 14 #include "base/strings/string16.h"
13 #include "base/strings/string_util.h" 15 #include "base/strings/string_util.h"
14 #include "base/strings/sys_string_conversions.h" 16 #include "base/strings/sys_string_conversions.h"
15 #include "base/strings/utf_string_conversions.h" 17 #include "base/strings/utf_string_conversions.h"
16 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 18 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
17 #include "chrome/browser/extensions/test_extension_system.h" 19 #include "chrome/browser/extensions/test_extension_system.h"
18 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h" 20 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h"
19 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h" 21 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"
20 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h" 22 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h"
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
659 [bar_ updateState:BookmarkBar::SHOW 661 [bar_ updateState:BookmarkBar::SHOW
660 changeType:BookmarkBar::DONT_ANIMATE_STATE_CHANGE]; 662 changeType:BookmarkBar::DONT_ANIMATE_STATE_CHANGE];
661 EXPECT_TRUE([bar_ dragShouldLockBarVisibility]); 663 EXPECT_TRUE([bar_ dragShouldLockBarVisibility]);
662 664
663 [bar_ updateState:BookmarkBar::DETACHED 665 [bar_ updateState:BookmarkBar::DETACHED
664 changeType:BookmarkBar::DONT_ANIMATE_STATE_CHANGE]; 666 changeType:BookmarkBar::DONT_ANIMATE_STATE_CHANGE];
665 EXPECT_FALSE([bar_ dragShouldLockBarVisibility]); 667 EXPECT_FALSE([bar_ dragShouldLockBarVisibility]);
666 } 668 }
667 669
668 TEST_F(BookmarkBarControllerTest, TagMap) { 670 TEST_F(BookmarkBarControllerTest, TagMap) {
669 int64 ids[] = { 1, 3, 4, 40, 400, 4000, 800000000, 2, 123456789 }; 671 int64_t ids[] = {1, 3, 4, 40, 400, 4000, 800000000, 2, 123456789};
670 std::vector<int32> tags; 672 std::vector<int32_t> tags;
671 673
672 // Generate some tags 674 // Generate some tags
673 for (unsigned int i = 0; i < arraysize(ids); i++) { 675 for (unsigned int i = 0; i < arraysize(ids); i++) {
674 tags.push_back([bar_ menuTagFromNodeId:ids[i]]); 676 tags.push_back([bar_ menuTagFromNodeId:ids[i]]);
675 } 677 }
676 678
677 // Confirm reverse mapping. 679 // Confirm reverse mapping.
678 for (unsigned int i = 0; i < arraysize(ids); i++) { 680 for (unsigned int i = 0; i < arraysize(ids); i++) {
679 EXPECT_EQ(ids[i], [bar_ nodeIdFromMenuTag:tags[i]]); 681 EXPECT_EQ(ids[i], [bar_ nodeIdFromMenuTag:tags[i]]);
680 } 682 }
(...skipping 17 matching lines...) Expand all
698 bookmarks::AddIfNotBookmarked(model, gurl, ASCIIToUTF16("small")); 700 bookmarks::AddIfNotBookmarked(model, gurl, ASCIIToUTF16("small"));
699 bookmarks::AddIfNotBookmarked( 701 bookmarks::AddIfNotBookmarked(
700 model, GURL("http://www.cnn.com"), ASCIIToUTF16("bigger title")); 702 model, GURL("http://www.cnn.com"), ASCIIToUTF16("bigger title"));
701 menu = [bar_ menuForFolderNode:model->bookmark_bar_node()]; 703 menu = [bar_ menuForFolderNode:model->bookmark_bar_node()];
702 EXPECT_EQ([menu numberOfItems], 2); 704 EXPECT_EQ([menu numberOfItems], 2);
703 NSMenuItem *item = [menu itemWithTitle:@"bigger title"]; 705 NSMenuItem *item = [menu itemWithTitle:@"bigger title"];
704 EXPECT_TRUE(item); 706 EXPECT_TRUE(item);
705 item = [menu itemWithTitle:@"small"]; 707 item = [menu itemWithTitle:@"small"];
706 EXPECT_TRUE(item); 708 EXPECT_TRUE(item);
707 if (item) { 709 if (item) {
708 int64 tag = [bar_ nodeIdFromMenuTag:[item tag]]; 710 int64_t tag = [bar_ nodeIdFromMenuTag:[item tag]];
709 const BookmarkNode* node = bookmarks::GetBookmarkNodeByID(model, tag); 711 const BookmarkNode* node = bookmarks::GetBookmarkNodeByID(model, tag);
710 EXPECT_TRUE(node); 712 EXPECT_TRUE(node);
711 EXPECT_EQ(gurl, node->url()); 713 EXPECT_EQ(gurl, node->url());
712 } 714 }
713 715
714 // Test with an actual folder as well 716 // Test with an actual folder as well
715 const BookmarkNode* parent = model->bookmark_bar_node(); 717 const BookmarkNode* parent = model->bookmark_bar_node();
716 const BookmarkNode* folder = model->AddFolder(parent, 718 const BookmarkNode* folder = model->AddFolder(parent,
717 parent->child_count(), 719 parent->child_count(),
718 ASCIIToUTF16("folder")); 720 ASCIIToUTF16("folder"));
(...skipping 1430 matching lines...) Expand 10 before | Expand all | Expand 10 after
2149 "2f3b ] 4b "); 2151 "2f3b ] 4b ");
2150 actual = bookmarks::test::ModelStringFromNode(root); 2152 actual = bookmarks::test::ModelStringFromNode(root);
2151 EXPECT_EQ(expected, actual); 2153 EXPECT_EQ(expected, actual);
2152 2154
2153 // Verify that the other bookmark folder can't be deleted. 2155 // Verify that the other bookmark folder can't be deleted.
2154 BookmarkButton *otherButton = [bar_ otherBookmarksButton]; 2156 BookmarkButton *otherButton = [bar_ otherBookmarksButton];
2155 EXPECT_FALSE([bar_ canDragBookmarkButtonToTrash:otherButton]); 2157 EXPECT_FALSE([bar_ canDragBookmarkButtonToTrash:otherButton]);
2156 } 2158 }
2157 2159
2158 } // namespace 2160 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698