Delay TypeProvider.objectType access until after dart:core resynthesizing.

Delay TypeProvider.objectType access until after dart:core resynthesizing.

This way we solve a chicken-and-egg problem with TypeProvider.

Fix for referencing elements from non-first part.

Fix for TODO to update implicit fields for a getter/setter pair.
The type List has it, so I have to fix it to use for SDK summaries.

Add SummaryTypeProvider to use with SDK summaries.
It is initialized in two steps: first dart:core, then dart:async libraries.
    resynthesizer = new SummaryResynthesizer(context, typeProvider,
        _getPrelinkedSummary, _getUnlinkedSummary, context.sourceFactory);
    _buildCoreLibrary();
    _buildAsyncLibrary();

  void _buildCoreLibrary() {
    LibraryElement library = resynthesizer.getLibraryElement('dart:core');
    typeProvider.initializeCore(library);
  }

  void _buildAsyncLibrary() {
    LibraryElement library = resynthesizer.getLibraryElement('dart:async');
    typeProvider.initializeAsync(library);
  }



R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/4b1048f80b04a0101f34ffbe8a311723fcf47d66

[Paul Berry, 2015-12-24 03:31:09]

lgtm

https://codereview.chromium.org/1543313002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1543313002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:231: List<ClassElementImpl>
delayedObjectSubclasses = <ClassElementImpl>[];
Please add a doc comment for this field.  Perhaps something like:

Classes which should have their supertype set to "object" once resynthesis is
complete.  Only used if [isCoreLibrary] is `true`.

https://codereview.chromium.org/1543313002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summary_sdk.dart (right):

https://codereview.chromium.org/1543313002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summary_sdk.dart:18: bool _initCore = false;
The meaning of these booleans isn't clear from their names.  How about renaming
to "_isCoreInitialized" and "_isAsyncInitialized"?

[scheglov, 2015-12-24 03:36:06]

https://codereview.chromium.org/1543313002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1543313002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:231: List<ClassElementImpl>
delayedObjectSubclasses = <ClassElementImpl>[];
On 2015/12/24 03:31:09, Paul Berry wrote:
> Please add a doc comment for this field.  Perhaps something like:
> 
> Classes which should have their supertype set to "object" once resynthesis is
> complete.  Only used if [isCoreLibrary] is `true`.

Done.

https://codereview.chromium.org/1543313002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summary_sdk.dart (right):

https://codereview.chromium.org/1543313002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summary_sdk.dart:18: bool _initCore = false;
On 2015/12/24 03:31:09, Paul Berry wrote:
> The meaning of these booleans isn't clear from their names.  How about
renaming
> to "_isCoreInitialized" and "_isAsyncInitialized"?

Done.

[scheglov, 2015-12-24 22:48:08]

Description was changed from

==========
Delay TypeProvider.objectType access until after dart:core resynthesizing.

This way we solve a chicken-and-egg problem with TypeProvider.

Fix for referencing elements from non-first part.

Fix for TODO to update implicit fields for a getter/setter pair.
The type List has it, so I have to fix it to use for SDK summaries.

Add SummaryTypeProvider to use with SDK summaries.
It is initialized in two steps: first dart:core, then dart:async libraries.
    resynthesizer = new SummaryResynthesizer(context, typeProvider,
        _getPrelinkedSummary, _getUnlinkedSummary, context.sourceFactory);
    _buildCoreLibrary();
    _buildAsyncLibrary();

  void _buildCoreLibrary() {
    LibraryElement library = resynthesizer.getLibraryElement('dart:core');
    typeProvider.initializeCore(library);
  }

  void _buildAsyncLibrary() {
    LibraryElement library = resynthesizer.getLibraryElement('dart:async');
    typeProvider.initializeAsync(library);
  }



R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Delay TypeProvider.objectType access until after dart:core resynthesizing.

This way we solve a chicken-and-egg problem with TypeProvider.

Fix for referencing elements from non-first part.

Fix for TODO to update implicit fields for a getter/setter pair.
The type List has it, so I have to fix it to use for SDK summaries.

Add SummaryTypeProvider to use with SDK summaries.
It is initialized in two steps: first dart:core, then dart:async libraries.
    resynthesizer = new SummaryResynthesizer(context, typeProvider,
        _getPrelinkedSummary, _getUnlinkedSummary, context.sourceFactory);
    _buildCoreLibrary();
    _buildAsyncLibrary();

  void _buildCoreLibrary() {
    LibraryElement library = resynthesizer.getLibraryElement('dart:core');
    typeProvider.initializeCore(library);
  }

  void _buildAsyncLibrary() {
    LibraryElement library = resynthesizer.getLibraryElement('dart:async');
    typeProvider.initializeAsync(library);
  }



R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/4b1048f80b04a0101f34ffbe8a311723fcf47d66
==========

[scheglov, 2015-12-24 22:48:09]

Committed patchset #2 (id:20001) manually as
4b1048f80b04a0101f34ffbe8a311723fcf47d66 (presubmit successful).

[Brian Wilkerson, 2015-12-27 16:42:44]

LGTM