Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1543293004: Switch to standard integer types in base/process/. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in base/process/. BUG=138542 TBR=mark@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/beced7ca85f2d2834045852aa4de47b83cf81358 Cr-Commit-Position: refs/heads/master@{#366810}

Patch Set 1 #

Patch Set 2 : ssize_t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -87 lines) Patch
M base/process/internal_linux.h View 3 chunks +5 lines, -3 lines 0 comments Download
M base/process/internal_linux.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/process/kill.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/kill_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/process/kill_win.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M base/process/launch.h View 1 chunk +4 lines, -1 line 0 comments Download
M base/process/launch.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/launch_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/process/memory.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/process/memory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/memory_linux.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M base/process/memory_mac.mm View 2 chunks +2 lines, -0 lines 0 comments Download
M base/process/memory_stubs.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/memory_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/process/memory_unittest_mac.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M base/process/memory_unittest_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/memory_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/process.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/process/process_handle_freebsd.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/process/process_handle_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/process_handle_openbsd.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/process/process_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/process/process_info_linux.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M base/process/process_info_mac.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/process/process_info_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/process/process_iterator.h View 1 chunk +3 lines, -1 line 0 comments Download
M base/process/process_iterator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/process_iterator_freebsd.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/process/process_iterator_linux.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/process/process_iterator_mac.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/process/process_iterator_openbsd.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/process/process_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/process_metrics.h View 6 chunks +25 lines, -21 lines 0 comments Download
M base/process/process_metrics.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M base/process/process_metrics_freebsd.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/process/process_metrics_ios.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/process_metrics_linux.cc View 11 chunks +25 lines, -21 lines 0 comments Download
M base/process/process_metrics_mac.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M base/process/process_metrics_nacl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/process_metrics_openbsd.cc View 2 chunks +4 lines, -1 line 0 comments Download
M base/process/process_metrics_posix.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M base/process/process_metrics_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M base/process/process_metrics_win.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M base/process/process_posix.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M base/process/process_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/process_util_unittest.cc View 5 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543293004/1
5 years ago (2015-12-24 03:37:58 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/131455)
5 years ago (2015-12-24 03:46:47 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/131455)
5 years ago (2015-12-24 03:46:49 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543293004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543293004/20001
5 years ago (2015-12-24 04:03:45 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/131466)
5 years ago (2015-12-24 04:11:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543293004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543293004/20001
5 years ago (2015-12-24 04:53:31 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-24 06:48:06 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-24 06:49:12 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/beced7ca85f2d2834045852aa4de47b83cf81358
Cr-Commit-Position: refs/heads/master@{#366810}

Powered by Google App Engine
This is Rietveld 408576698