Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1543283002: Re-land 'Fold out-of-flow objects into anonymous blocks when removing children' (Closed)

Created:
5 years ago by rhogan
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land 'Fold out-of-flow objects into anonymous blocks when removing children' Another attempt at https://codereview.chromium.org/1406163003. Sometimes when we remove a child we end up with a float or out-of-flow object beside an anonymous block. When that happens, fold the float/out-of-flow object into the anonymous box as that is where it would have lived if they were siblings in the first place. BUG=322039 Committed: https://crrev.com/c579aa1f40cf26e7fe3c21e5cd9e0bc7b81497a5 Cr-Commit-Position: refs/heads/master@{#367074}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/add-float-after-anonymous-block-being-destroyed.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/add-float-after-anonymous-block-being-destroyed-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/add-inline-before-float-and-into-anonymous-block-container.html View 1 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/add-inline-before-float-and-into-anonymous-block-container-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/remove-div-after-float-and-before-anonymous-block-container.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/remove-div-after-float-and-before-anonymous-block-container-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/remove-div-after-float-and-before-anonymous-block-container-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 3 chunks +35 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
rhogan
4 years, 12 months ago (2015-12-24 09:09:22 UTC) #4
mstensho (USE GERRIT)
lgtm, but I think there's an unintended accidental in TestExpectations. https://codereview.chromium.org/1543283002/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1543283002/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode261 ...
4 years, 11 months ago (2015-12-29 13:42:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543283002/20001
4 years, 11 months ago (2015-12-29 15:36:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2015-12-29 16:58:57 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c579aa1f40cf26e7fe3c21e5cd9e0bc7b81497a5 Cr-Commit-Position: refs/heads/master@{#367074}
4 years, 11 months ago (2015-12-29 17:00:09 UTC) #11
inferno
4 years, 11 months ago (2015-12-30 18:32:49 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1558433003/ by inferno@chromium.org.

The reason for reverting is: Ton of use-after-free security regressions.
BUG=573281.

Powered by Google App Engine
This is Rietveld 408576698