src/compiler/js-generic-lowering.cc - Issue 1543253002: Basic TurboFan support for rest arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-generic-lowering.cc

Issue 1543253002: Basic TurboFan support for rest arguments. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-generic-lowering.cc

diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc

index db8db500369c6cc007bfae8433de0e6cc311c4fc..eeb3aca6ebbfe137d564d10ac31014be6cc98add 100644

--- a/src/compiler/js-generic-lowering.cc

+++ b/src/compiler/js-generic-lowering.cc

@@ -463,7 +463,8 @@ void JSGenericLowering::LowerJSCreateArguments(Node* node) {

ReplaceWithRuntimeCall(node, Runtime::kNewStrictArguments_Generic);

break;

case CreateArgumentsParameters::kRestArray:

- UNIMPLEMENTED();

+ node->InsertInput(zone(), 1, jsgraph()->Constant(p.start_index()));

+ ReplaceWithRuntimeCall(node, Runtime::kNewStrictRestArguments_Generic);

break;

}