Basic TurboFan support for rest arguments.

Basic TurboFan support for rest arguments.

TurboFan can accept them, it calls a runtime function to initialize
the rest object as a JSArray.

BUG=
R=bmeurer@chromium.org

Committed: https://crrev.com/66b0d0315fd545c78d2c16b9f3ec4bd6b0ea7c71
Cr-Commit-Position: refs/heads/master@{#33071}

[mvstanton, 2015-12-23 14:00:05]

Hi Benedikt, here is the basic turbofan support.
Next in the series will be an optimized path.

Also, I fixed the numbering pass to allow crankshaft to fail over to TurboFan if
it sees icky rest args.

[Benedikt Meurer, 2015-12-27 07:34:31]

Thanks. LGTM once comments are addressed.

https://codereview.chromium.org/1543253002/diff/1/src/runtime/runtime-scopes.cc
File src/runtime/runtime-scopes.cc (right):

https://codereview.chromium.org/1543253002/diff/1/src/runtime/runtime-scopes....
src/runtime/runtime-scopes.cc:525: Handle<JSObject>
NewStrictRestArguments(Isolate* isolate,
Same here: NewRestArguments.

https://codereview.chromium.org/1543253002/diff/1/src/runtime/runtime.h
File src/runtime/runtime.h (right):

https://codereview.chromium.org/1543253002/diff/1/src/runtime/runtime.h#newco...
src/runtime/runtime.h:566: F(NewStrictRestArguments_Generic, 2, 1)  \
This name is confusing; rest arguments don't depend on the language mode. Please
rename to NewRestArguments_Generic.

[mvstanton, 2015-12-31 11:18:05]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-12-31 11:18:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1543253002/#ps20001
(title: "Code comments.")

[commit-bot: I haz the power, 2015-12-31 11:18:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1543253002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1543253002/20001

[mvstanton, 2015-12-31 11:26:59]

Thanks Benedikt. BTW, I have an optimized patch as well, but there is a bug that
an EXTERNAL_POINTER is being smi-tagged, despite my linkage directives. But I
get ahead of myself...Gute Rutsch! --Mike

https://codereview.chromium.org/1543253002/diff/1/src/runtime/runtime-scopes.cc
File src/runtime/runtime-scopes.cc (right):

https://codereview.chromium.org/1543253002/diff/1/src/runtime/runtime-scopes....
src/runtime/runtime-scopes.cc:525: Handle<JSObject>
NewStrictRestArguments(Isolate* isolate,
On 2015/12/27 07:34:30, Benedikt Meurer wrote:
> Same here: NewRestArguments.

Done.

https://codereview.chromium.org/1543253002/diff/1/src/runtime/runtime.h
File src/runtime/runtime.h (right):

https://codereview.chromium.org/1543253002/diff/1/src/runtime/runtime.h#newco...
src/runtime/runtime.h:566: F(NewStrictRestArguments_Generic, 2, 1)  \
On 2015/12/27 07:34:30, Benedikt Meurer wrote:
> This name is confusing; rest arguments don't depend on the language mode.
Please
> rename to NewRestArguments_Generic.

Done.

[commit-bot: I haz the power, 2015-12-31 11:56:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-31 11:56:42]

Description was changed from

==========
Basic TurboFan support for rest arguments.

TurboFan can accept them, it calls a runtime function to initialize
the rest object as a JSArray.

BUG=
R=bmeurer@chromium.org
==========

to

==========
Basic TurboFan support for rest arguments.

TurboFan can accept them, it calls a runtime function to initialize
the rest object as a JSArray.

BUG=
R=bmeurer@chromium.org

Committed: https://crrev.com/66b0d0315fd545c78d2c16b9f3ec4bd6b0ea7c71
Cr-Commit-Position: refs/heads/master@{#33071}
==========

[commit-bot: I haz the power, 2015-12-31 11:56:43]

Patchset 2 (id:??) landed as
https://crrev.com/66b0d0315fd545c78d2c16b9f3ec4bd6b0ea7c71
Cr-Commit-Position: refs/heads/master@{#33071}