Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Unified Diff: components/search_engines/template_url.cc

Issue 1543203002: Remove a variety of no-longer-used query params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/search_engines/template_url.h ('k') | components/search_engines/template_url_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/search_engines/template_url.cc
diff --git a/components/search_engines/template_url.cc b/components/search_engines/template_url.cc
index b5baebed16dc8367e6b4c6abfc06c6e2d7a41663..a75779bfb0d1cfe09f393076650d7671f5e13ca3 100644
--- a/components/search_engines/template_url.cc
+++ b/components/search_engines/template_url.cc
@@ -148,9 +148,7 @@ TemplateURLRef::SearchTermsArgs::SearchTermsArgs(
input_type(metrics::OmniboxInputType::INVALID),
accepted_suggestion(NO_SUGGESTIONS_AVAILABLE),
cursor_position(base::string16::npos),
- enable_omnibox_start_margin(false),
page_classification(metrics::OmniboxEventProto::INVALID_SPEC),
- bookmark_bar_pinned(false),
append_extra_query_params(false),
force_instant_results(false),
from_app_list(false),
@@ -571,8 +569,6 @@ bool TemplateURLRef::ParseParameter(size_t start,
replacements->push_back(Replacement(GOOGLE_BASE_URL, start));
} else if (parameter == "google:baseSuggestURL") {
replacements->push_back(Replacement(GOOGLE_BASE_SUGGEST_URL, start));
- } else if (parameter == "google:bookmarkBarPinned") {
- replacements->push_back(Replacement(GOOGLE_BOOKMARK_BAR_PINNED, start));
} else if (parameter == "google:currentPageUrl") {
replacements->push_back(Replacement(GOOGLE_CURRENT_PAGE_URL, start));
} else if (parameter == "google:cursorPosition") {
@@ -602,10 +598,6 @@ bool TemplateURLRef::ParseParameter(size_t start,
start));
} else if (parameter == "google:instantExtendedEnabledKey") {
url->insert(start, google_util::kInstantExtendedAPIParam);
- } else if (parameter == "google:ntpIsThemedParameter") {
- replacements->push_back(Replacement(GOOGLE_NTP_IS_THEMED, start));
- } else if (parameter == "google:omniboxStartMarginParameter") {
- replacements->push_back(Replacement(GOOGLE_OMNIBOX_START_MARGIN, start));
} else if (parameter == "google:contextualSearchVersion") {
replacements->push_back(
Replacement(GOOGLE_CONTEXTUAL_SEARCH_VERSION, start));
@@ -904,17 +896,6 @@ std::string TemplateURLRef::HandleReplacements(
&url);
break;
- case GOOGLE_BOOKMARK_BAR_PINNED:
- if (search_terms_data.IsShowingSearchTermsOnSearchResultsPages()) {
- // Log whether the bookmark bar is pinned when the user is seeing
- // InstantExtended on the SRP.
- DCHECK(!i->is_post_param);
- HandleReplacement(
- "bmbp", search_terms_args.bookmark_bar_pinned ? "1" : "0", *i,
- &url);
- }
- break;
-
case GOOGLE_CURRENT_PAGE_URL:
DCHECK(!i->is_post_param);
if (!search_terms_args.current_page_url.empty()) {
@@ -959,23 +940,6 @@ std::string TemplateURLRef::HandleReplacements(
&url);
break;
- case GOOGLE_NTP_IS_THEMED:
- DCHECK(!i->is_post_param);
- HandleReplacement(
- std::string(), search_terms_data.NTPIsThemedParam(), *i, &url);
- break;
-
- case GOOGLE_OMNIBOX_START_MARGIN:
- DCHECK(!i->is_post_param);
- if (search_terms_args.enable_omnibox_start_margin) {
- int omnibox_start_margin = search_terms_data.OmniboxStartMargin();
- if (omnibox_start_margin >= 0) {
- HandleReplacement("es_sm", base::IntToString(omnibox_start_margin),
- *i, &url);
- }
- }
- break;
-
case GOOGLE_CONTEXTUAL_SEARCH_VERSION:
if (search_terms_args.contextual_search_params.version >= 0) {
HandleReplacement(
« no previous file with comments | « components/search_engines/template_url.h ('k') | components/search_engines/template_url_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698