Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: components/search_engines/search_terms_data.h

Issue 1543203002: Remove a variety of no-longer-used query params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/search_engines/prepopulated_engines.json ('k') | components/search_engines/search_terms_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/search_engines/search_terms_data.h
diff --git a/components/search_engines/search_terms_data.h b/components/search_engines/search_terms_data.h
index 2cd5951f8b49e8501e52412c4b84e338c0970cc2..0ac6159124c3a14b223e57837070dbcdacc601b1 100644
--- a/components/search_engines/search_terms_data.h
+++ b/components/search_engines/search_terms_data.h
@@ -49,10 +49,6 @@ class SearchTermsData {
// This implementation returns the empty string.
virtual std::string GetSuggestRequestIdentifier() const;
- // Returns true if search terms are shown in the omnibox on search results
- // pages.
- virtual bool IsShowingSearchTermsOnSearchResultsPages() const;
-
// Returns a string indicating whether InstantExtended is enabled.
virtual std::string InstantExtendedEnabledParam(bool for_search) const;
@@ -60,16 +56,6 @@ class SearchTermsData {
// incrementally.
virtual std::string ForceInstantResultsParam(bool for_prerender) const;
- // Returns the start-edge margin of the omnibox in pixels.
- virtual int OmniboxStartMargin() const;
-
- // Returns a string indicating whether a non-default theme is active,
- // suitable for adding as a query string param to the homepage. This only
- // applies if Instant Extended is enabled. Returns an empty string otherwise.
- // Determining this requires accessing the Profile, so this can only ever be
- // non-empty for UIThreadSearchTermsData.
- virtual std::string NTPIsThemedParam() const;
-
// Returns a string indicating which webview is currently in use on iOS,
// suitable for adding as a query string param to search requests. Returns an
// empty string if no parameter should be passed along with search requests.
« no previous file with comments | « components/search_engines/prepopulated_engines.json ('k') | components/search_engines/search_terms_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698