Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10868)

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 1543203002: Remove a variety of no-longer-used query params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/searchbox/searchbox_extension.cc
diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc
index 2b20a417af332ae38b9c7863d9d40149c7b3c836..5dc7ae5ac91322ffd16f8e7eede21a2f2d861a8b 100644
--- a/chrome/renderer/searchbox/searchbox_extension.cc
+++ b/chrome/renderer/searchbox/searchbox_extension.cc
@@ -353,17 +353,6 @@ static const char kDispatchKeyCaptureChangeScript[] =
" true;"
"}";
-static const char kDispatchMarginChangeEventScript[] =
- "if (window.chrome &&"
- " window.chrome.embeddedSearch &&"
- " window.chrome.embeddedSearch.searchBox &&"
- " window.chrome.embeddedSearch.searchBox.onmarginchange &&"
- " typeof window.chrome.embeddedSearch.searchBox.onmarginchange =="
- " 'function') {"
- " window.chrome.embeddedSearch.searchBox.onmarginchange();"
- " true;"
- "}";
-
static const char kDispatchMostVisitedChangedScript[] =
"if (window.chrome &&"
" window.chrome.embeddedSearch &&"
@@ -466,9 +455,6 @@ class SearchBoxExtensionWrapper : public v8::Extension {
static void GetSearchRequestParams(
const v8::FunctionCallbackInfo<v8::Value>& args);
- // Gets the start-edge margin to use with extended Instant.
- static void GetStartMargin(const v8::FunctionCallbackInfo<v8::Value>& args);
-
// Gets the current top suggestion to prefetch search results.
static void GetSuggestionToPrefetch(
const v8::FunctionCallbackInfo<v8::Value>& args);
@@ -591,11 +577,6 @@ void SearchBoxExtension::DispatchKeyCaptureChange(blink::WebFrame* frame) {
}
// static
-void SearchBoxExtension::DispatchMarginChange(blink::WebFrame* frame) {
- Dispatch(frame, kDispatchMarginChangeEventScript);
-}
-
-// static
void SearchBoxExtension::DispatchMostVisitedChanged(
blink::WebFrame* frame) {
Dispatch(frame, kDispatchMostVisitedChangedScript);
@@ -649,8 +630,6 @@ SearchBoxExtensionWrapper::GetNativeFunctionTemplate(
return v8::FunctionTemplate::New(isolate, GetRightToLeft);
if (name->Equals(v8::String::NewFromUtf8(isolate, "GetSearchRequestParams")))
return v8::FunctionTemplate::New(isolate, GetSearchRequestParams);
- if (name->Equals(v8::String::NewFromUtf8(isolate, "GetStartMargin")))
- return v8::FunctionTemplate::New(isolate, GetStartMargin);
if (name->Equals(v8::String::NewFromUtf8(isolate, "GetSuggestionToPrefetch")))
return v8::FunctionTemplate::New(isolate, GetSuggestionToPrefetch);
if (name->Equals(v8::String::NewFromUtf8(isolate, "GetThemeBackgroundInfo")))
@@ -894,15 +873,6 @@ void SearchBoxExtensionWrapper::GetSearchRequestParams(
}
// static
-void SearchBoxExtensionWrapper::GetStartMargin(
- const v8::FunctionCallbackInfo<v8::Value>& args) {
- content::RenderView* render_view = GetRenderView();
- if (!render_view) return;
- args.GetReturnValue().Set(static_cast<int32_t>(
- SearchBox::Get(render_view)->start_margin()));
-}
-
-// static
void SearchBoxExtensionWrapper::GetSuggestionToPrefetch(
const v8::FunctionCallbackInfo<v8::Value>& args) {
content::RenderView* render_view = GetRenderView();
« no previous file with comments | « chrome/renderer/searchbox/searchbox_extension.h ('k') | chrome/test/data/diagnostics/user/Default/Preferences » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698