Add a GetFullHashWithApis method to Protocol Manager.

chrome/browser/safe_browsing/protocol_manager.cc

Index: chrome/browser/safe_browsing/protocol_manager.cc
diff --git a/chrome/browser/safe_browsing/protocol_manager.cc b/chrome/browser/safe_browsing/protocol_manager.cc
index e746763c7b99f505bc0fe58d20cf5e651e4ab2ed..2ac7c7b4afefce06e058fef382a0d684f85ffd12 100644
--- a/chrome/browser/safe_browsing/protocol_manager.cc
+++ b/chrome/browser/safe_browsing/protocol_manager.cc
@@ -4,6 +4,7 @@
 
 #include "chrome/browser/safe_browsing/protocol_manager.h"
 
+#include "base/base64.h"
 #include "base/environment.h"
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
@@ -89,6 +90,9 @@ static const size_t kSbMaxBackOff = 8;
 
 const char kUmaHashResponseMetricName[] = "SB2.GetHashResponseOrErrorCode";
 
+// The V4 URL prefix where browser fetches hashes from the V4 server.
+const char kSbV4URLPrefix[] = "https://safebrowsing.googleapis.com/v4";

[Nathan Parker, 2016/01/05 22:44:00]

kSbV4UrlPrefix

[kcarattini, 2016/01/05 23:30:57]

Done.

+
 // The default SBProtocolManagerFactory.
 class SBProtocolManagerFactoryImpl : public SBProtocolManagerFactory {
  public:
@@ -193,6 +197,10 @@ SafeBrowsingProtocolManager::~SafeBrowsingProtocolManager() {
   STLDeleteContainerPairFirstPointers(hash_requests_.begin(),
                                       hash_requests_.end());
   hash_requests_.clear();
+
+  STLDeleteContainerPairFirstPointers(v4_hash_requests_.begin(),
+                                      v4_hash_requests_.end());
+  v4_hash_requests_.clear();
 }
 
 // We can only have one update or chunk request outstanding, but there may be
@@ -228,6 +236,59 @@ void SafeBrowsingProtocolManager::GetFullHash(
   fetcher->Start();
 }
 
+std::string SafeBrowsingProtocolManager::GetV4HashRequest(
+    const std::vector<SBPrefix>& prefixes,
+    ThreatType threat_type) {
+  // Build the request. Client info and client states are not added to the
+  // request protocol buffer. Client info is passed as params in the url.
+  FindFullHashesRequest req;
+  ThreatInfo* info = req.mutable_threat_info();
+  info->add_threat_types(threat_type);
+  info->add_platform_types(CHROME_PLATFORM);
+  info->add_threat_entry_types(URL_EXPRESSION);
+  for (const SBPrefix& prefix : prefixes) {
+    std::string hash;

[Nathan Parker, 2016/01/05 22:44:00]

nit: I think you can do
std::string hash(ptr, size)

[kcarattini, 2016/01/05 23:30:57]

Done.

+    hash.append(reinterpret_cast<const char*>(&prefix), sizeof(SBPrefix));
+    info->add_threat_entries()->set_hash(hash);
+  }
+
+  // Serialize and Base64 encode.
+  std::string req_data, req_base64;
+  req.SerializeToString(&req_data);
+  base::Base64Encode(req_data, &req_base64);
+
+  return req_base64;
+}
+
+void SafeBrowsingProtocolManager::GetV4FullHashes(
+    const std::vector<SBPrefix>& prefixes,
+    ThreatType threat_type,
+    FullHashCallback callback) {
+  DCHECK(CalledOnValidThread());
+  // TODO(kcarattini): Implement backoff behavior.
+
+  std::string req_base64 = GetV4HashRequest(prefixes, threat_type);
+  GURL gethash_url = GetV4HashUrl(req_base64);
+
+  net::URLFetcher* fetcher =
+      net::URLFetcher::Create(url_fetcher_id_++, gethash_url,
+                              net::URLFetcher::GET, this)

[kcarattini, 2015/12/29 22:33:41]

Changed to GET as per offline discussion with awoz.

+          .release();
+  // TODO(kcarattini): Implement a new response processor.
+  v4_hash_requests_[fetcher] = FullHashDetails(callback,
+                                               false  /* is_download */);
+
+  fetcher->SetLoadFlags(net::LOAD_DISABLE_CACHE);
+  fetcher->SetRequestContext(request_context_getter_.get());
+  fetcher->Start();
+}
+
+void SafeBrowsingProtocolManager::GetFullHashesWithApis(
+    const std::vector<SBPrefix>& prefixes,
+    FullHashCallback callback) {
+  GetV4FullHashes(prefixes, API_ABUSE, callback);
+}
+
 void SafeBrowsingProtocolManager::GetNextUpdate() {
   DCHECK(CalledOnValidThread());
   if (request_.get() || request_type_ != NO_REQUEST)
@@ -758,6 +819,15 @@ GURL SafeBrowsingProtocolManager::GetHashUrl(bool is_extended_reporting) const {
   return GURL(url);
 }
 
+// The API hash call uses the pver4 Safe Browsing server.
+GURL SafeBrowsingProtocolManager::GetV4HashUrl(
+    const std::string& request_base64) const {
+  std::string url = SafeBrowsingProtocolManagerHelper::ComposePver4Url(
+      kSbV4URLPrefix, "encodedFullHashes",
+      request_base64, client_name_, version_);
+  return GURL(url);
+}
+
 GURL SafeBrowsingProtocolManager::NextChunkUrl(const std::string& url) const {
   DCHECK(CalledOnValidThread());
   std::string next_url;