Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1543063002: Roll DEPS for V8 to 9e8b756. (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Lei Zhang
TBR Rolling past https://chromium.googlesource.com/v8/v8/+/70a7c754bf3445a8b783b75ca2a7aa34cdeb080b requires a bit more work. I'll do that in a separate ...
5 years ago (2015-12-22 23:59:02 UTC) #3
Lei Zhang
Committed patchset #1 (id:1) manually as 302199492ef6260010310002bb2280433fd2a194 (presubmit successful).
5 years ago (2015-12-22 23:59:30 UTC) #5
Lei Zhang
5 years ago (2015-12-23 00:07:49 UTC) #6
Message was sent while issue was closed.
Well, that failed on Windows with:

FAILED: ninja -t msvc -e environment.x86 -- "C:\Program Files (x86)\Microsoft
Visual Studio 12.0\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC
@obj\v8\src\compiler\v8_base_2.escape-analysis.obj.rsp /c
..\..\v8\src\compiler\escape-analysis.cc
/Foobj\v8\src\compiler\v8_base_2.escape-analysis.obj
/Fdobj\v8\tools\gyp\v8_base_2.cc.pdb 
e:\b\build\slave\windows\build\pdfium\v8\src\compiler\escape-analysis.cc(989) :
error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\windows\build\pdfium\v8\src\compiler\escape-analysis.cc(989) :
warning C4244: 'argument' : conversion from 'const double' to 'size_t', possible
loss of data
e:\b\build\slave\windows\build\pdfium\v8\src\compiler\escape-analysis.cc(1197) :
warning C4244: 'initializing' : conversion from 'const double' to 'int',
possible loss of data
e:\b\build\slave\windows\build\pdfium\v8\src\compiler\escape-analysis.cc(1212) :
warning C4244: 'initializing' : conversion from 'const double' to 'int',
possible loss of data
e:\b\build\slave\windows\build\pdfium\v8\src\compiler\escape-analysis.cc(1256) :
warning C4244: 'initializing' : conversion from 'const double' to 'int',
possible loss of data

So reverting. I'll try to roll again closer to ToT when I have a Windows
computer to test with.

Powered by Google App Engine
This is Rietveld 408576698