extensions/common/permissions/usb_device_permission.cc - Issue 1543053002: Switch to standard integer types in extensions/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/usb_device_permission.cc

Issue 1543053002: Switch to standard integer types in extensions/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@int-extensions-browser

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/permissions/usb_device_permission.h ('k') | extensions/common/permissions/usb_device_permission_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/usb_device_permission.cc

diff --git a/extensions/common/permissions/usb_device_permission.cc b/extensions/common/permissions/usb_device_permission.cc

index ab9a936f470699d96eb36fc0ed142e36f882b081..ab279b6d85726a21fd4f0c96e6a94878977ca2ce 100644

--- a/extensions/common/permissions/usb_device_permission.cc

+++ b/extensions/common/permissions/usb_device_permission.cc

@@ -28,7 +28,7 @@ UsbDevicePermission::~UsbDevicePermission() {}

PermissionIDSet UsbDevicePermission::GetPermissions() const {

PermissionIDSet ids;

- std::set<uint16> unknown_product_vendors;

+ std::set<uint16_t> unknown_product_vendors;

bool found_unknown_vendor = false;

for (const UsbDevicePermissionData& data : data_set_) {

@@ -49,7 +49,7 @@ PermissionIDSet UsbDevicePermission::GetPermissions() const {

}

- for (uint16 vendor_id : unknown_product_vendors) {

+ for (uint16_t vendor_id : unknown_product_vendors) {

const char* vendor = device::UsbIds::GetVendorName(vendor_id);

DCHECK(vendor);

ids.insert(APIPermission::kUsbDeviceUnknownProduct,