Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1543043006: win: Stop disabling compiler warning 4481. (Closed)

Created:
4 years, 12 months ago by Nico
Modified:
4 years, 12 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Stop disabling compiler warning 4481. The warning predates C++11. override is no longer a non-standard extension. BUG=none Committed: https://crrev.com/67b3d7f0c42f2e5af855feb67de574ffae58a9a8 Cr-Commit-Position: refs/heads/master@{#366832}

Patch Set 1 #

Patch Set 2 : gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 12 months ago (2015-12-24 15:08:25 UTC) #2
Lei Zhang
lgtm And here we are. :)
4 years, 12 months ago (2015-12-24 18:34:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543043006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543043006/20001
4 years, 12 months ago (2015-12-24 18:34:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 12 months ago (2015-12-24 18:38:00 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-24 18:39:05 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/67b3d7f0c42f2e5af855feb67de574ffae58a9a8
Cr-Commit-Position: refs/heads/master@{#366832}

Powered by Google App Engine
This is Rietveld 408576698